Skip to content

Commit 660a497

Browse files
Cleanup
1 parent c35d720 commit 660a497

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

packages/firestore/lite/src/api/components.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import { FirebaseFirestore, Settings } from './database';
2222
import { DatabaseId, DatabaseInfo } from '../../../src/core/database_info';
2323
import { logDebug } from '../../../src/util/log';
2424
import { Code, FirestoreError } from '../../../src/util/error';
25+
import { FirestoreSettings } from '../../../src/api/database';
2526

2627
export const LOG_TAG = 'ComponentProvider';
2728

@@ -87,14 +88,14 @@ export function removeComponents(firestore: FirebaseFirestore): void {
8788
export function makeDatabaseInfo(
8889
databaseId: DatabaseId,
8990
persistenceKey: string,
90-
settings: Settings
91+
settings: FirestoreSettings
9192
): DatabaseInfo {
9293
return new DatabaseInfo(
9394
databaseId,
9495
persistenceKey,
95-
settings.host ?? DEFAULT_HOST,
96-
settings.ssl ?? DEFAULT_SSL,
97-
/* forceLongPolling= */ false,
98-
/* forceAutoDetectLongPolling= */ true
96+
settings.host,
97+
settings.ssl,
98+
settings.experimentalForceLongPolling,
99+
settings.experimentalAutoDetectLongPolling
99100
);
100101
}

packages/firestore/src/api/database.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ import {
154154
LRU_DEFAULT_CACHE_SIZE_BYTES,
155155
LRU_MINIMUM_CACHE_SIZE_BYTES
156156
} from '../local/lru_garbage_collector';
157+
import { makeDatabaseInfo } from '../../lite/src/api/components';
157158

158159
// settings() defaults:
159160
const DEFAULT_HOST = 'firestore.googleapis.com';
@@ -662,13 +663,10 @@ export function configureFirestore(firestore: FirestoreCompat): void {
662663
'configureFirestore() called multiple times'
663664
);
664665

665-
const databaseInfo = new DatabaseInfo(
666+
const databaseInfo = makeDatabaseInfo(
666667
firestore._databaseId,
667668
firestore._persistenceKey,
668-
settings.host,
669-
settings.ssl,
670-
settings.experimentalForceLongPolling,
671-
settings.experimentalAutoDetectLongPolling
669+
settings
672670
);
673671
firestore._firestoreClient = new FirestoreClient(
674672
firestore._credentials,

0 commit comments

Comments
 (0)