wip

Author: var-const

packages/firestore/src/local/indexeddb_mutation_queue.ts

@@ -18,6 +18,7 @@ import { Timestamp } from '../api/timestamp';
 import { User } from '../auth/user';
 import { Query } from '../core/query';
 import { BatchId, ProtoByteString } from '../core/types';
+import { DocumentKeySet } from '../model/collections';
 import { DocumentKey } from '../model/document_key';
 import { Mutation } from '../model/mutation';
 import { BATCHID_UNKNOWN, MutationBatch } from '../model/mutation_batch';
@@ -362,6 +363,39 @@ export class IndexedDbMutationQueue implements MutationQueue {
       .next(() => results);
   }
 
+  getAllMutationBatchesAffectingDocumentKeys(
+    transaction: PersistenceTransaction,
+    documentKeys: DocumentKeySet
+  ): PersistencePromise<MutationBatch[]> {
+    const minKey = DbDocumentMutation.prefixForPath(
+      this.userId,
+      documentKeys.first().path
+    );
+    const maxKey = DbDocumentMutation.prefixForPath(
+      this.userId,
+      documentKeys.first().path
+    );
+    const keyRange = IDBKeyRange.bound(minKey, maxKey);
+    let uniqueBatchIDs = new SortedSet<BatchId>(primitiveComparator);
+
+    const results: MutationBatch[] = [];
+    return documentMutationsStore(transaction)
+      .iterate({ range: keyRange }, (indexKey, _, control) => {
+        const [userID, encodedPath, batchID] = indexKey;
+        const path = EncodedResourcePath.decode(encodedPath);
+        if (userID !== this.userId) {
+          control.done();
+          return;
+        }
+
+        if (!documentKeys.has(new DocumentKey(path))) {
+          return;
+        }
+        uniqueBatchIDs = uniqueBatchIDs.add(batchID);
+      })
+    .next(() => this.lookupMutationBatches(transaction, uniqueBatchIDs));
+  }
+
   getAllMutationBatchesAffectingQuery(
     transaction: PersistenceTransaction,
     query: Query
@@ -413,29 +447,33 @@ export class IndexedDbMutationQueue implements MutationQueue {
         }
         uniqueBatchIDs = uniqueBatchIDs.add(batchID);
       })
-      .next(() => {
-        const results: MutationBatch[] = [];
-        const promises: Array<PersistencePromise<void>> = [];
-        // TODO(rockwood): Implement this using iterate.
-        uniqueBatchIDs.forEach(batchID => {
-          const mutationKey = this.keyForBatchId(batchID);
-          promises.push(
-            mutationsStore(transaction)
-              .get(mutationKey)
-              .next(mutation => {
-                if (mutation === null) {
-                  fail(
-                    'Dangling document-mutation reference found, ' +
-                      'which points to ' +
-                      mutationKey
-                  );
-                }
-                results.push(this.serializer.fromDbMutationBatch(mutation!));
-              })
-          );
-        });
-        return PersistencePromise.waitFor(promises).next(() => results);
-      });
+      .next(() => this.lookupMutationBatches(transaction, uniqueBatchIDs));
+  }
+
+  private lookupMutationBatches(
+    transaction: PersistenceTransaction,
+    batchIDs: SortedSet<BatchId>) : PersistencePromise<MutationBatch[]> {
+    const results: MutationBatch[] = [];
+    const promises: Array<PersistencePromise<void>> = [];
+    // TODO(rockwood): Implement this using iterate.
+    batchIDs.forEach(batchID => {
+      const mutationKey = this.keyForBatchId(batchID);
+      promises.push(
+        mutationsStore(transaction)
+          .get(mutationKey)
+          .next(mutation => {
+            if (mutation === null) {
+              fail(
+                'Dangling document-mutation reference found, ' +
+                  'which points to ' +
+                  mutationKey
+              );
+            }
+            results.push(this.serializer.fromDbMutationBatch(mutation!));
+          })
+      );
+    });
+    return PersistencePromise.waitFor(promises).next(() => results);
   }
 
   removeMutationBatches(

packages/firestore/src/local/mutation_queue.ts

@@ -17,6 +17,7 @@
 import { Timestamp } from '../api/timestamp';
 import { Query } from '../core/query';
 import { BatchId, ProtoByteString } from '../core/types';
+import { DocumentKeySet } from '../model/collections';
 import { DocumentKey } from '../model/document_key';
 import { Mutation } from '../model/mutation';
 import { MutationBatch } from '../model/mutation_batch';
@@ -150,6 +151,23 @@ export interface MutationQueue extends GarbageSource {
     documentKey: DocumentKey
   ): PersistencePromise<MutationBatch[]>;
 
+  /**
+   * Finds all mutation batches that could possibly affect the given
+   * set of document keys. Not all mutations in a batch will necessarily affect
+   * each key, so when looping through the batch you'll need to
+   * check that the mutation itself matches the key.
+   *
+   * Note that because of this requirement implementations are free to return
+   * mutation batches that don't contain any of the document keys at all if it's
+   * convenient.
+   */
+  // TODO(mcg): This should really return an enumerator
+  // also for b/32992024, all backing stores should really index by document key
+  getAllMutationBatchesAffectingDocumentKeys(
+    transaction: PersistenceTransaction,
+    documentKeys: DocumentKeySet
+  ): PersistencePromise<MutationBatch[]>;
+
   /**
    * Finds all mutation batches that could affect the results for the given
    * query. Not all mutations in a batch will necessarily affect the query, so