Merge branch 'master' into ch-heartbeat

Author: hsubox76

.changeset/curvy-brooms-clean.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix bug where `user.providerData` field was being improperly initialized

.github/CODEOWNERS

@@ -33,7 +33,7 @@
 
 
 # These owners will be the default owners for everything in the repo.
-*       @Feiyang1 @hiranya911 @hsubox76 @firebase/jssdk-global-approvers
+*       @allspain @hsubox76 @firebase/jssdk-global-approvers
 
 # Database Code
 packages/database @schmidt-sebastian @jsdt @firebase/jssdk-global-approvers
@@ -79,20 +79,20 @@ packages/performance-compat @jposuna @firebase/jssdk-global-approvers
 packages/performance-types @jposuna @firebase/jssdk-global-approvers
 
 # Analytics Code
-packages/analytics @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
-packages/analytics-compat @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
-packages/analytics-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
+packages/analytics @hsubox76 @firebase/jssdk-global-approvers
+packages/analytics-compat @hsubox76 @firebase/jssdk-global-approvers
+packages/analytics-types @hsubox76 @firebase/jssdk-global-approvers
 
 # Remote Config Code
 packages/remote-config @erikeldridge @firebase/jssdk-global-approvers
 packages/remote-config-compat  @erikeldridge @firebase/jssdk-global-approvers
 packages/remote-config-types @erikeldridge @firebase/jssdk-global-approvers
 
 # App Check Code
-packages/app-check @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
-packages/app-check-compat @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
-packages/app-check-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
-packages/app-check-interop-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
+packages/app-check @hsubox76 @firebase/jssdk-global-approvers
+packages/app-check-compat @hsubox76 @firebase/jssdk-global-approvers
+packages/app-check-types @hsubox76 @firebase/jssdk-global-approvers
+packages/app-check-interop-types @hsubox76 @firebase/jssdk-global-approvers
 
 # Documentation Changes
 packages/firebase/index.d.ts @egilmorez @firebase/jssdk-global-approvers

.github/workflows/e2e-test.yml

@@ -19,57 +19,59 @@ jobs:
         working-directory: './e2e'
 
     steps:
-    - name: Checkout Repo
-      uses: actions/checkout@master
-    - name: Set up Node (12)
-      uses: actions/setup-node@v2
-      with:
-        node-version: 12.x
-    - name: install Chrome stable
-      run: |
-        sudo apt-get update
-        sudo apt-get install google-chrome-stable
-    - name: Bump Node memory limit
-      run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
-    - name: Write project config
-      env:
-        PROJECT_CONFIG: ${{ secrets.TEST_PROJECT_CONFIG }}
-        TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
-      run: |
-        echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
-    - name: Yarn install
-      run: |
-        echo "Installing firebase@${{ github.event.inputs.versionOrTag }}"
-        yarn add firebase@${{ github.event.inputs.versionOrTag }}
-        yarn
-    - name: Deploy "callTest" cloud function
-      run: |
-        pushd functions
-        npm install
-        popd
-        npx firebase-tools deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
-      working-directory: ./config
-      env:
-        FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
-    - name: Run modular tests
-      env:
-        APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
-      run: xvfb-run yarn test:modular
-    - name: Run compat tests
-      env:
-        APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
-      run: xvfb-run yarn test:compat
-    - name: Tests succeeded
-      if: success()
-      run: node scripts/ci/notify-test-result.js success
-      env:
-        WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
-      # run in root
-      working-directory: '.'
-    - name: Tests failed
-      if: failure()
-      run: node scripts/ci/notify-test-result.js fail
-      env:
-        WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
-      # run in root
-      working-directory: '.'
+      - name: Checkout Repo
+        uses: actions/checkout@master
+      - name: Set up Node (12)
+        uses: actions/setup-node@v2
+        with:
+          node-version: 12.x
+      - name: install Chrome stable
+        run: |
+          sudo apt-get update
+          sudo apt-get install google-chrome-stable
+      - name: Bump Node memory limit
+        run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
+      - name: Write project config
+        env:
+          PROJECT_CONFIG: ${{ secrets.TEST_PROJECT_CONFIG }}
+          TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
+        run: |
+          echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
+      - name: Yarn install
+        run: |
+          echo "Installing firebase@${{ github.event.inputs.versionOrTag }}"
+          yarn add firebase@${{ github.event.inputs.versionOrTag }}
+          yarn
+      - name: Deploy "callTest" cloud function
+        run: |
+          pushd functions
+          npm install
+          popd
+          npx firebase-tools deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
+        working-directory: ./config
+        env:
+          FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
+      - name: Run modular tests
+        env:
+          APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
+        run: xvfb-run yarn test:modular
+      - name: Run compat tests
+        env:
+          APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
+        run: xvfb-run yarn test:compat
+      - name: Tests succeeded
+        if: success()
+        run: node scripts/ci/notify-test-result.js success
+        env:
+          WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
+          RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
+        # run in root
+        working-directory: '.'
+      - name: Tests failed
+        if: failure()
+        run: node scripts/ci/notify-test-result.js fail
+        env:
+          WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
+          RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
+        # run in root
+        working-directory: '.'

.github/workflows/health-metrics-test.yml renamed to .github/workflows/health-metrics-pull-request.yml

@@ -3,8 +3,14 @@ name: Health Metrics
 on: [push, pull_request]
 
 env:
-  METRICS_SERVICE_URL: ${{ secrets.METRICS_SERVICE_URL }}
   GITHUB_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
+  # TODO(yifany): parse from git commit history directly
+  #   Reason: actions/checkout@v2 does not always honor ${{ github.event.pull_request.base.sha }},
+  #           therefore "base.sha" sometimes is not the commit that actually gets merged with the
+  #           pull request head commit for CI test.
+  #   See:
+  #     - https://github.com/actions/checkout/issues/27
+  #     - https://github.com/actions/checkout/issues/237
   GITHUB_PULL_REQUEST_BASE_SHA: ${{ github.event.pull_request.base.sha }}
   NODE_OPTIONS: "--max-old-space-size=4096"
 

.github/workflows/health-metrics-release.yml

@@ -0,0 +1,19 @@
+name: Health Metrics
+
+on:
+  push:
+    tags: ['**']
+
+jobs:
+  release-diffing:
+    name: Release Diffing
+    runs-on: ubuntu-latest
+    steps:
+      - uses: google-github-actions/setup-gcloud@master
+        with:
+          service_account_key: ${{ secrets.GCP_SA_KEY }}
+      - uses: FirebaseExtended/github-actions/health-metrics/release-diffing@master
+        with:
+          repo: ${{ github.repository }}
+          ref: ${{ github.ref }}
+          commit: ${{ github.sha }}

.github/workflows/release-log.yml

@@ -20,4 +20,6 @@ jobs:
           node-version: 14.x
 
       - name: Get PR number and send to tracker.
-        run: node scripts/ci/log-changesets.js
+        run: node scripts/ci/log-changesets.js
+        env:
+          RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}

.vscode/launch.json

@@ -29,16 +29,12 @@
       "program": "${workspaceRoot}/node_modules/.bin/_mocha",
       "cwd": "${workspaceRoot}/packages/firestore",
       "args": [
-        "--require", "ts-node/register/type-check",
+        "--require", "babel-register.js",
         "--require", "index.node.ts",
         "--timeout", "5000",
         "test/{,!(browser|integration)/**/}*.test.ts",
         "--exit"
       ],
-      "env": {
-        "TS_NODE_CACHE": "NO",
-        "TS_NODE_COMPILER_OPTIONS" : "{\"module\":\"commonjs\"}"
-      },
       "sourceMaps": true,
       "protocol": "inspector"
     },
@@ -49,17 +45,15 @@
       "program": "${workspaceRoot}/node_modules/.bin/_mocha",
       "cwd": "${workspaceRoot}/packages/firestore",
       "args": [
-        "--require", "ts-node/register/type-check",
+        "--require", "babel-register.js",
         "--require", "index.node.ts",
         "--require", "test/util/node_persistence.ts",
         "--timeout", "5000",
         "test/{,!(browser|integration)/**/}*.test.ts",
         "--exit"
       ],
       "env": {
-        "USE_MOCK_PERSISTENCE": "YES",
-        "TS_NODE_CACHE": "NO",
-        "TS_NODE_COMPILER_OPTIONS" : "{\"module\":\"commonjs\"}"
+        "USE_MOCK_PERSISTENCE": "YES"
       },
       "sourceMaps": true,
       "protocol": "inspector"
@@ -71,15 +65,13 @@
       "program": "${workspaceRoot}/node_modules/.bin/_mocha",
       "cwd": "${workspaceRoot}/packages/firestore",
       "args": [
-        "--require", "ts-node/register/type-check",
+        "--require", "babel-register.js",
         "--require", "index.node.ts",
         "--timeout", "5000",
         "test/{,!(browser|unit)/**/}*.test.ts",
         "--exit"
       ],
       "env": {
-        "TS_NODE_CACHE": "NO",
-        "TS_NODE_COMPILER_OPTIONS" : "{\"module\":\"commonjs\"}",
         "FIRESTORE_EMULATOR_PORT" : "8080",
         "FIRESTORE_EMULATOR_PROJECT_ID" :  "test-emulator"
       },
@@ -93,7 +85,7 @@
       "program": "${workspaceRoot}/node_modules/.bin/_mocha",
       "cwd": "${workspaceRoot}/packages/firestore",
       "args": [
-        "--require", "ts-node/register/type-check",
+        "--require", "babel-register.js",
         "--require", "index.node.ts",
         "--require", "test/util/node_persistence.ts",
         "--timeout", "5000",
@@ -102,8 +94,6 @@
       ],
       "env": {
         "USE_MOCK_PERSISTENCE": "YES",
-        "TS_NODE_CACHE": "NO",
-        "TS_NODE_COMPILER_OPTIONS" : "{\"module\":\"commonjs\"}",
         "FIRESTORE_EMULATOR_PORT" : "8080",
         "FIRESTORE_EMULATOR_PROJECT_ID" :  "test-emulator"
       },

common/api-review/auth.api.md

@@ -601,6 +601,11 @@ export class PhoneMultiFactorGenerator {
     static FACTOR_ID: string;
 }
 
+// @public
+export interface PhoneMultiFactorInfo extends MultiFactorInfo {
+    readonly phoneNumber: string;
+}
+
 // @public
 export interface PhoneMultiFactorSignInInfoOptions {
     multiFactorHint?: MultiFactorInfo;

common/api-review/firestore-lite.api.md

@@ -6,6 +6,7 @@
 
 import { EmulatorMockTokenOptions } from '@firebase/util';
 import { FirebaseApp } from '@firebase/app';
+import { FirebaseError } from '@firebase/util';
 import { LogLevelString as LogLevel } from '@firebase/logger';
 
 // @public
@@ -147,10 +148,9 @@ export interface FirestoreDataConverter<T> {
 }
 
 // @public
-export class FirestoreError extends Error {
+export class FirestoreError extends FirebaseError {
     readonly code: FirestoreErrorCode;
     readonly message: string;
-    readonly name: string;
     readonly stack?: string;
 }
 

common/api-review/firestore.api.md

@@ -6,6 +6,7 @@
 
 import { EmulatorMockTokenOptions } from '@firebase/util';
 import { FirebaseApp } from '@firebase/app';
+import { FirebaseError } from '@firebase/util';
 import { LogLevelString as LogLevel } from '@firebase/logger';
 
 // @public
@@ -177,10 +178,9 @@ export interface FirestoreDataConverter<T> {
 }
 
 // @public
-export class FirestoreError extends Error {
+export class FirestoreError extends FirebaseError {
     readonly code: FirestoreErrorCode;
     readonly message: string;
-    readonly name: string;
     readonly stack?: string;
 }
 

common/api-review/storage.api.md

@@ -77,14 +77,15 @@ export class _FirebaseStorageImpl implements FirebaseStorage {
     _getAuthToken(): Promise<string | null>;
     get host(): string;
     set host(host: string);
+    // Warning: (ae-forgotten-export) The symbol "ConnectionType" needs to be exported by the entry point index.d.ts
     // Warning: (ae-forgotten-export) The symbol "RequestInfo" needs to be exported by the entry point index.d.ts
     // Warning: (ae-forgotten-export) The symbol "Connection" needs to be exported by the entry point index.d.ts
     // Warning: (ae-forgotten-export) The symbol "Request" needs to be exported by the entry point index.d.ts
     //
     // (undocumented)
-    _makeRequest<T>(requestInfo: RequestInfo_2<T>, requestFactory: () => Connection, authToken: string | null, appCheckToken: string | null): Request_2<T>;
+    _makeRequest<I extends ConnectionType, O>(requestInfo: RequestInfo_2<I, O>, requestFactory: () => Connection<I>, authToken: string | null, appCheckToken: string | null): Request_2<O>;
     // (undocumented)
-    makeRequestWithTokens<T>(requestInfo: RequestInfo_2<T>, requestFactory: () => Connection): Promise<T>;
+    makeRequestWithTokens<I extends ConnectionType, O>(requestInfo: RequestInfo_2<I, O>, requestFactory: () => Connection<I>): Promise<O>;
     _makeStorageReference(loc: _Location): _Reference;
     get maxOperationRetryTime(): number;
     set maxOperationRetryTime(time: number);
@@ -112,6 +113,12 @@ export interface FullMetadata extends UploadMetadata {
     updated: string;
 }
 
+// @public
+export function getBlob(ref: StorageReference, maxDownloadSizeBytes?: number): Promise<Blob>;
+
+// @public
+export function getBytes(ref: StorageReference, maxDownloadSizeBytes?: number): Promise<ArrayBuffer>;
+
 // @internal (undocumented)
 export function _getChild(ref: StorageReference, childPath: string): _Reference;
 
@@ -124,6 +131,9 @@ export function getMetadata(ref: StorageReference): Promise<FullMetadata>;
 // @public
 export function getStorage(app?: FirebaseApp, bucketUrl?: string): FirebaseStorage;
 
+// @public
+export function getStream(ref: StorageReference, maxDownloadSizeBytes?: number): NodeJS.ReadableStream;
+
 // Warning: (ae-forgotten-export) The symbol "StorageError" needs to be exported by the entry point index.d.ts
 //
 // @internal (undocumented)

config/mocharc.node.js

@@ -34,4 +34,9 @@ if (process.env.CI) {
   config.reporter = 'min';
 }
 
+// Firestore uses babel to compile tests in Nodejs
+if (process.env.NO_TS_NODE) {
+  delete config.require;
+}
+
 module.exports = config;

e2e/package.json

@@ -35,6 +35,6 @@
     "typescript": "4.3.4",
     "webpack": "5.41.1",
     "webpack-cli": "4.7.2",
-    "webpack-dev-server": "3.10.1"
+    "webpack-dev-server": "4.7.3"
   }
 }