Skip to content

Commit 5d7f272

Browse files
WIP Tree-Shake Sync Engine Listen
1 parent 453d2f9 commit 5d7f272

File tree

8 files changed

+651
-440
lines changed

8 files changed

+651
-440
lines changed

packages/firestore/exp/dependencies.json

Lines changed: 181 additions & 16 deletions
Large diffs are not rendered by default.

packages/firestore/src/core/event_manager.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@ import { debugAssert } from '../util/assert';
1919
import { EventHandler } from '../util/misc';
2020
import { ObjectMap } from '../util/obj_map';
2121
import { canonifyQuery, Query, queryEquals, stringifyQuery } from './query';
22-
import { SyncEngine, SyncEngineListener } from './sync_engine';
22+
import {
23+
SyncEngine,
24+
SyncEngineListener,
25+
listen,
26+
unlisten
27+
} from './sync_engine';
2328
import { OnlineState } from './types';
2429
import { ChangeType, DocumentViewChange, ViewSnapshot } from './view_snapshot';
2530
import { wrapInUserErrorIfRecoverable } from '../util/async_queue';
@@ -72,7 +77,7 @@ export class EventManager implements SyncEngineListener {
7277

7378
if (firstListen) {
7479
try {
75-
queryInfo.viewSnap = await this.syncEngine.listen(query);
80+
queryInfo.viewSnap = await listen(this.syncEngine, query);
7681
} catch (e) {
7782
const firestoreError = wrapInUserErrorIfRecoverable(
7883
e,
@@ -116,7 +121,7 @@ export class EventManager implements SyncEngineListener {
116121

117122
if (lastListen) {
118123
this.queries.delete(query);
119-
return this.syncEngine.unlisten(query);
124+
return unlisten(this.syncEngine, query);
120125
}
121126
}
122127

0 commit comments

Comments
 (0)