Skip to content

Commit 5b68ce2

Browse files
dconeybedconeybe
committed
Remove the no-android tag from bloom filter spec tests, now that the feature has been merged into the android sdk in firebase/firebase-android-sdk#4982 
1 parent e45fea9 commit 5b68ce2

File tree

3 files changed

+14
-28
lines changed

3 files changed

+14
-28
lines changed

‎packages/firestore/test/unit/specs/existence_filter_spec.test.ts

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,8 @@ describeSpec('Existence Filters:', [], () => {
277277
*/
278278
specTest(
279279
'Full re-query is skipped when bloom filter can identify documents deleted',
280-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
281280
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
282-
['no-ios', 'no-android'],
281+
['no-ios'],
283282
() => {
284283
const query1 = query('collection');
285284
const docA = doc('collection/a', 1000, { v: 1 });
@@ -311,9 +310,8 @@ describeSpec('Existence Filters:', [], () => {
311310

312311
specTest(
313312
'Full re-query is triggered when bloom filter can not identify documents deleted',
314-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
315313
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
316-
['no-ios', 'no-android'],
314+
['no-ios'],
317315
() => {
318316
const query1 = query('collection');
319317
const docA = doc('collection/a', 1000, { v: 1 });
@@ -345,9 +343,8 @@ describeSpec('Existence Filters:', [], () => {
345343

346344
specTest(
347345
'Bloom filter can process special characters in document name',
348-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
349346
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
350-
['no-ios', 'no-android'],
347+
['no-ios'],
351348
() => {
352349
const query1 = query('collection');
353350
const docA = doc('collection/ÀÒ∑', 1000, { v: 1 });
@@ -375,9 +372,8 @@ describeSpec('Existence Filters:', [], () => {
375372

376373
specTest(
377374
'Bloom filter fills in default values for undefined padding and hashCount',
378-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
379375
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
380-
['no-ios', 'no-android'],
376+
['no-ios'],
381377
() => {
382378
const query1 = query('collection');
383379
const docA = doc('collection/a', 1000, { v: 1 });
@@ -449,9 +445,8 @@ describeSpec('Existence Filters:', [], () => {
449445

450446
specTest(
451447
'Full re-query is triggered when bloom filter hashCount is invalid',
452-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
453448
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
454-
['no-ios', 'no-android'],
449+
['no-ios'],
455450
() => {
456451
const query1 = query('collection');
457452
const docA = doc('collection/a', 1000, { v: 1 });
@@ -485,9 +480,8 @@ describeSpec('Existence Filters:', [], () => {
485480

486481
specTest(
487482
'Full re-query is triggered when bloom filter is empty',
488-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
489483
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
490-
['no-ios', 'no-android'],
484+
['no-ios'],
491485
() => {
492486
const query1 = query('collection');
493487
const docA = doc('collection/a', 1000, { v: 1 });
@@ -522,9 +516,8 @@ describeSpec('Existence Filters:', [], () => {
522516

523517
specTest(
524518
'Same documents can have different bloom filters',
525-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
526519
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
527-
['no-ios', 'no-android'],
520+
['no-ios'],
528521
() => {
529522
const query1 = query('collection', filter('v', '<=', 2));
530523
const query2 = query('collection', filter('v', '>=', 2));
@@ -574,9 +567,8 @@ describeSpec('Existence Filters:', [], () => {
574567

575568
specTest(
576569
'Bloom filter is handled at global snapshot',
577-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
578570
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
579-
['no-ios', 'no-android'],
571+
['no-ios'],
580572
() => {
581573
const query1 = query('collection');
582574
const docA = doc('collection/a', 1000, { v: 1 });
@@ -608,9 +600,8 @@ describeSpec('Existence Filters:', [], () => {
608600

609601
specTest(
610602
'Bloom filter limbo resolution is denied',
611-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
612603
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
613-
['no-ios', 'no-android'],
604+
['no-ios'],
614605
() => {
615606
const query1 = query('collection');
616607
const docA = doc('collection/a', 1000, { v: 1 });
@@ -640,9 +631,8 @@ describeSpec('Existence Filters:', [], () => {
640631

641632
specTest(
642633
'Bloom filter with large size works as expected',
643-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
644634
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
645-
['no-ios', 'no-android'],
635+
['no-ios'],
646636
() => {
647637
const query1 = query('collection');
648638
const docs = [];

‎packages/firestore/test/unit/specs/limbo_spec.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -929,9 +929,8 @@ describeSpec('Limbo Documents:', [], () => {
929929

930930
specTest(
931931
'Limbo resolution throttling with bloom filter application',
932-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
933932
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
934-
['no-ios', 'no-android'],
933+
['no-ios'],
935934
() => {
936935
const query1 = query('collection');
937936
const docA1 = doc('collection/a1', 1000, { key: 'a1' });

‎packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1812,9 +1812,8 @@ describeSpec('Listens:', [], () => {
18121812

18131813
specTest(
18141814
'Resuming a query should specify expectedCount when adding the target',
1815-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
18161815
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
1817-
['no-ios', 'no-android'],
1816+
['no-ios'],
18181817
() => {
18191818
const query1 = query('collection');
18201819
const docA = doc('collection/a', 1000, { key: 'a' });
@@ -1848,9 +1847,8 @@ describeSpec('Listens:', [], () => {
18481847

18491848
specTest(
18501849
'Resuming a query should specify expectedCount that does not include pending mutations',
1851-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
18521850
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
1853-
['no-ios', 'no-android'],
1851+
['no-ios'],
18541852
() => {
18551853
const query1 = query('collection');
18561854
const docA = doc('collection/a', 1000, { key: 'a' });
@@ -1879,9 +1877,8 @@ describeSpec('Listens:', [], () => {
18791877

18801878
specTest(
18811879
'ExpectedCount in listen request should work after coming back online',
1882-
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
18831880
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
1884-
['no-ios', 'no-android'],
1881+
['no-ios'],
18851882
() => {
18861883
const query1 = query('collection');
18871884
const docA = doc('collection/a', 1000, { key: 'a' });

0 commit comments

Comments
 (0)