Lint

Author: schmidt-sebastian

packages/firestore/src/model/document.ts

@@ -84,7 +84,7 @@ export class Document extends MaybeDocument {
       return this.objectValue.field(path);
     } else {
       assert(
-        this.proto != undefined && this.converter != undefined,
+        this.proto !== undefined && this.converter !== undefined,
         'Expected proto and converter to be defined.'
       );
 
@@ -98,23 +98,23 @@ export class Document extends MaybeDocument {
 
       let fieldValue = this.fieldValueCache.get(canonicalPath);
 
-      if (fieldValue == undefined) {
+      if (fieldValue === undefined) {
         // Instead of deserializing the full Document proto, we only
         // deserialize the value at the requested field path. This speeds up
         // Query execution as query filters can discard documents based on a
         // single field.
         let protoValue: api.Value | undefined = this.proto!.fields[
           path.firstSegment()
         ];
-        for (let i = 1; protoValue != undefined && i < path.length; ++i) {
+        for (let i = 1; protoValue !== undefined && i < path.length; ++i) {
           if (protoValue.mapValue) {
             protoValue = protoValue.mapValue.fields[path.get(i)];
           } else {
             protoValue = undefined;
           }
         }
 
-        if (protoValue == undefined) {
+        if (protoValue === undefined) {
           fieldValue = null;
         } else {
           fieldValue = this.converter!(protoValue);
@@ -135,7 +135,7 @@ export class Document extends MaybeDocument {
   data(): ObjectValue {
     if (!this.objectValue) {
       assert(
-        this.proto != undefined && this.converter != undefined,
+        this.proto !== undefined && this.converter !== undefined,
         'Expected proto and converter to be defined.'
       );
 

packages/firestore/src/remote/serializer.ts

@@ -528,8 +528,8 @@ export class JsonProtoSerializer {
     document: api.Document,
     hasCommittedMutations?: boolean
   ): Document {
-    let key = this.fromName(document.name!);
-    let version = this.fromVersion(document.updateTime!);
+    const key = this.fromName(document.name!);
+    const version = this.fromVersion(document.updateTime!);
     return new Document(
       key,
       version,

packages/firestore/test/integration/api/database.test.ts

@@ -1112,7 +1112,7 @@ apiDescribe('Database', (persistence: boolean) => {
     });
   });
 
-  it.only('calling shutdown mutiple times should proceed', async () => {
+  it('calling shutdown mutiple times should proceed', async () => {
     await withTestDoc(persistence, async docRef => {
       const firestore = docRef.firestore;
       await shutdownDb(firestore);