Skip to content

Commit 5267a4f

Browse files
committed
make FirebaseApp tests work again
1 parent af4fdc4 commit 5267a4f

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

packages/app-types/index.d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { Provider } from "@firebase/component";
2+
13
/**
24
* @license
35
* Copyright 2017 Google Inc.
@@ -100,4 +102,4 @@ export interface FirebaseNamespace {
100102

101103
// The current SDK version.
102104
SDK_VERSION: string;
103-
}
105+
}

packages/app/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const initializeApp = firebaseNamespace.initializeApp;
4444
// TODO: This disable can be removed and the 'ignoreRestArgs' option added to
4545
// the no-explicit-any rule when ESlint releases it.
4646
// eslint-disable-next-line @typescript-eslint/no-explicit-any
47-
firebaseNamespace.initializeApp = function(...args: any) {
47+
firebaseNamespace.initializeApp = function (...args: any) {
4848
// Environment check before initializing app
4949
// Do the check in initializeApp, so people have a chance to disable it by setting logLevel
5050
// in @firebase/logger

packages/app/test/firebaseApp.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ function firebaseAppTests(
315315
}
316316

317317
class TestService implements FirebaseService {
318-
constructor(private app_: FirebaseApp, public instanceIdentifier?: string) {}
318+
constructor(private app_: FirebaseApp, public instanceIdentifier?: string) { }
319319

320320
// TODO(koss): Shouldn't this just be an added method on
321321
// the service instance?

0 commit comments

Comments
 (0)