Skip to content

Commit 4f84138

Browse files
author
Brian Chen
committed
update md files
1 parent 8af2407 commit 4f84138

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

common/api-review/firestore-lite.api.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,9 @@ export function orderBy(fieldPath: string | FieldPath, directionStr?: OrderByDir
204204
export type OrderByDirection = 'desc' | 'asc';
205205

206206
// @public
207-
export type PartialWithFieldValue<T> = Partial<WithFieldValue<T>>;
207+
export type PartialWithFieldValue<T> = Partial<T> | (T extends Primitive ? T : T extends {} ? {
208+
[K in keyof T]?: PartialWithFieldValue<T[K]> | FieldValue;
209+
} : never);
208210

209211
// @public
210212
export type Primitive = string | number | boolean | undefined | null;
@@ -352,7 +354,7 @@ export type WhereFilterOp = '<' | '<=' | '==' | '!=' | '>=' | '>' | 'array-conta
352354
// @public
353355
export type WithFieldValue<T> = T | (T extends Primitive ? T : T extends {} ? {
354356
[K in keyof T]: WithFieldValue<T[K]> | FieldValue;
355-
} : Partial<T>);
357+
} : never);
356358

357359
// @public
358360
export class WriteBatch {

common/api-review/firestore.api.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,9 @@ export function orderBy(fieldPath: string | FieldPath, directionStr?: OrderByDir
328328
export type OrderByDirection = 'desc' | 'asc';
329329

330330
// @public
331-
export type PartialWithFieldValue<T> = Partial<WithFieldValue<T>>;
331+
export type PartialWithFieldValue<T> = Partial<T> | (T extends Primitive ? T : T extends {} ? {
332+
[K in keyof T]?: PartialWithFieldValue<T[K]> | FieldValue;
333+
} : never);
332334

333335
// @public
334336
export interface PersistenceSettings {
@@ -504,7 +506,7 @@ export type WhereFilterOp = '<' | '<=' | '==' | '!=' | '>=' | '>' | 'array-conta
504506
// @public
505507
export type WithFieldValue<T> = T | (T extends Primitive ? T : T extends {} ? {
506508
[K in keyof T]: WithFieldValue<T[K]> | FieldValue;
507-
} : Partial<T>);
509+
} : never);
508510

509511
// @public
510512
export class WriteBatch {

0 commit comments

Comments
 (0)