Cleanup

Author: schmidt-sebastian

packages/firestore/src/local/indexeddb_schema.ts

@@ -25,8 +25,7 @@ import { encode, EncodedResourcePath } from './encoded_resource_path';
 export const SCHEMA_VERSION = 2;
 
 /**
- * Performs database creation and schema migrations from and up to the specified
- * version.
+ * Performs database creation and schema migrations up to schema version 2.
  */
 export function createOrUpgradeDb(
   db: IDBDatabase,
@@ -506,7 +505,7 @@ function createQueryCache(db: IDBDatabase): void {
 
 /**
  * An object representing the changes at a particular snapshot version for the
- * given target. This is used to facilitate storing a query changelog in the
+ * given target. This is used to facilitate storing query changelogs in the
  * targetChanges object store.
  *
  * PORTING NOTE: This is used for change propagation during multi-tab syncing
@@ -548,7 +547,7 @@ function createTargetChangeStore(db: IDBDatabase): void {
 /**
  * A record of the metadata state of each instance.
  *
- * PORTING NOTE: This is used for primary-tab selection for multi-tab
+ * PORTING NOTE: This is used for primary-tab selection to support multi-tab
  * persistence and does not need to be ported to iOS or Android.
  */
 export class DbInstanceMetadata {

packages/firestore/test/unit/local/schema_migration.test.ts

@@ -24,12 +24,12 @@ import {
 } from '../../../src/local/indexeddb_schema';
 import { Deferred } from '../../../src/util/promise';
 
-const INDEXEDDB_SCHEMA_TEST = 'schemaTest';
+const INDEXEDDB_TEST_DATABASE = 'schemaTest';
 
 function deleteDb() {
   const deferred = new Deferred<void>();
 
-  const request = window.indexedDB.deleteDatabase(INDEXEDDB_SCHEMA_TEST);
+  const request = window.indexedDB.deleteDatabase(INDEXEDDB_TEST_DATABASE);
   request.onsuccess = (event: Event) => {
     deferred.resolve();
   };
@@ -43,7 +43,7 @@ function deleteDb() {
 function initDb(targetVersion) {
   const deferred = new Deferred<IDBDatabase>();
 
-  const request = window.indexedDB.open(INDEXEDDB_SCHEMA_TEST, targetVersion);
+  const request = window.indexedDB.open(INDEXEDDB_TEST_DATABASE, targetVersion);
   request.onsuccess = (event: Event) => {
     const db = (event.target as IDBOpenDBRequest).result;
     deferred.resolve(db);
@@ -68,7 +68,7 @@ function getAllObjectStores(db: IDBDatabase): String[] {
   return objectStores;
 }
 
-// Sorting these stored directly should not affect the functionality of the SDK.
+// Sorting these arrays directly should not affect the functionality of the SDK.
 V1_STORES.sort();
 ALL_STORES.sort();