Remove nodePatches.ts hackery. (#2144)

This had some very stale code to:
1. Make it possible to use long-polling instead of WebSockets from the Node.JS SDK. This existed purely for testing purposes, wasn't reliable, and hasn't been used in ages.
2. Work around a bad Node.JS bug that was fixed 6 years ago (nodejs/node-v0.x-archive#6506).

Author: Michael Lehenbauer

packages/database/CHANGELOG.md

@@ -1,4 +1,7 @@
 # Unreleased
+- [changed] Internal cleanup to Node.JS support.
+
+# 6.4.0
 - [fixed] Fixed an issue that caused `.info/serverTimeOffset` events not to fire (#2043).
 - [changed] Treat `ns` url query parameter as the default Realtime Database
   namespace name.

packages/database/index.node.ts

@@ -25,10 +25,13 @@ import { enableLogging } from './src/core/util/util';
 import { RepoManager } from './src/core/RepoManager';
 import * as INTERNAL from './src/api/internal';
 import * as TEST_ACCESS from './src/api/test_access';
-import './src/nodePatches';
 import * as types from '@firebase/database-types';
 import { setSDKVersion } from './src/core/version';
 import { CONSTANTS, isNodeSdk } from '@firebase/util';
+import { setWebSocketImpl } from './src/realtime/WebSocketConnection';
+import { Client } from 'faye-websocket';
+
+setWebSocketImpl(Client);
 
 const ServerValue = Database.ServerValue;
 

packages/database/package.json

@@ -16,7 +16,7 @@
     "test": "yarn test:emulator",
     "test:all": "run-p test:browser test:node",
     "test:browser": "karma start --single-run",
-    "test:node": "TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/nodePatches.ts --opts ../../config/mocha.node.opts",
+    "test:node": "TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file index.node.ts --opts ../../config/mocha.node.opts",
     "test:emulator": "ts-node --compiler-options='{\"module\":\"commonjs\"}' ../../scripts/emulator-testing/database-test-runner.ts",
     "prepare": "yarn build"
   },

packages/database/src/nodePatches.ts

@@ -209,7 +209,6 @@ export class BrowserPollConnection implements Transport {
         urlParams[LAST_SESSION_PARAM] = this.lastSessionId;
       }
       if (
-        !isNodeSdk() &&
         typeof location !== 'undefined' &&
         location.href &&
         location.href.indexOf(FORGE_DOMAIN) !== -1
@@ -252,17 +251,21 @@ export class BrowserPollConnection implements Transport {
 
   // Static method, use string literal so it can be accessed in a generic way
   static isAvailable() {
-    // NOTE: In React-Native there's normally no 'document', but if you debug a React-Native app in
-    // the Chrome debugger, 'document' is defined, but document.createElement is null (2015/06/08).
-    return (
-      BrowserPollConnection.forceAllow_ ||
-      (!BrowserPollConnection.forceDisallow_ &&
+    if (isNodeSdk()) {
+      return false;
+    } else if (BrowserPollConnection.forceAllow_) {
+      return true;
+    } else {
+      // NOTE: In React-Native there's normally no 'document', but if you debug a React-Native app in
+      // the Chrome debugger, 'document' is defined, but document.createElement is null (2015/06/08).
+      return (
+        !BrowserPollConnection.forceDisallow_ &&
         typeof document !== 'undefined' &&
         document.createElement != null &&
         !isChromeExtensionContentScript() &&
-        !isWindowsStoreApp() &&
-        !isNodeSdk())
-    );
+        !isWindowsStoreApp()
+      );
+    }
   }
 
   /**
@@ -542,15 +545,6 @@ export class FirebaseIFrameScriptHolder {
       }, Math.floor(0));
     }
 
-    if (isNodeSdk() && this.myID) {
-      const urlParams: { [k: string]: string } = {};
-      urlParams[FIREBASE_LONGPOLL_DISCONN_FRAME_PARAM] = 't';
-      urlParams[FIREBASE_LONGPOLL_ID_PARAM] = this.myID;
-      urlParams[FIREBASE_LONGPOLL_PW_PARAM] = this.myPW;
-      const theURL = this.urlFn(urlParams);
-      (FirebaseIFrameScriptHolder as any).nodeRestRequest(theURL);
-    }
-
     // Protect from being called recursively.
     const onDisconnect = this.onDisconnect;
     if (onDisconnect) {