Make maxConcurrentLimboResolutions a required parameter of the SyncEngine constructor.

Author: dconeybe

packages/firestore/src/core/firestore_client.ts

@@ -53,6 +53,7 @@ import { OnlineState, OnlineStateSource } from './types';
 import { ViewSnapshot } from './view_snapshot';
 
 const LOG_TAG = 'FirestoreClient';
+const MAX_CONCURRENT_LIMBO_RESOLUTIONS = 100;
 
 /** DOMException error code constants. */
 const DOM_EXCEPTION_INVALID_STATE = 11;
@@ -369,7 +370,8 @@ export class FirestoreClient {
           this.localStore,
           this.remoteStore,
           this.sharedClientState,
-          user
+          user,
+          MAX_CONCURRENT_LIMBO_RESOLUTIONS
         );
 
         this.sharedClientState.onlineStateHandler = sharedClientStateOnlineStateChangedHandler;

packages/firestore/src/core/sync_engine.ts

@@ -188,7 +188,7 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
     // PORTING NOTE: Manages state synchronization in multi-tab environments.
     private sharedClientState: SharedClientState,
     private currentUser: User,
-    private maxConcurrentLimboResolutions: number = 100
+    private maxConcurrentLimboResolutions: number
   ) {}
 
   // Only used for testing.

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -511,22 +511,13 @@ abstract class TestRunner {
       remoteStoreOnlineStateChangedHandler,
       connectivityMonitor
     );
-    if (this.maxConcurrentLimboResolutions) {
-      this.syncEngine = new SyncEngine(
-        this.localStore,
-        this.remoteStore,
-        this.sharedClientState,
-        this.user,
-        this.maxConcurrentLimboResolutions
-      );
-    } else {
-      this.syncEngine = new SyncEngine(
-        this.localStore,
-        this.remoteStore,
-        this.sharedClientState,
-        this.user
-      );
-    }
+    this.syncEngine = new SyncEngine(
+      this.localStore,
+      this.remoteStore,
+      this.sharedClientState,
+      this.user,
+      this.maxConcurrentLimboResolutions ?? Number.MAX_SAFE_INTEGER
+    );
 
     // Set up wiring between sync engine and other components
     this.remoteStore.syncEngine = this.syncEngine;