no firestore

Author: wu-hui

.github/workflows/test-changed-firestore.yml

@@ -44,12 +44,12 @@ jobs:
         id: set-output
         run: echo "CHANGED=true" >> "$GITHUB_OUTPUT";
       - name: Archive build
-        if: ${{ !cancelled() }}
+        if: ${{ !cancelled() && steps.build.outcome != 'success' }}
         run: |
           tar -cf build.tar --exclude="\.git" .
           gzip build.tar
       - name: Upload build archive
-        if: ${{ !cancelled() }}
+        if: ${{ !cancelled() && steps.build.outcome != 'success' }}
         uses: actions/upload-artifact@v3
         with:
           name: build.tar.gz

packages/firestore/test/integration/api/database.test.ts

@@ -831,7 +831,6 @@ apiDescribe('Database', persistence => {
           expect(snap.data()).to.deep.equal(changedData);
           // This event could be a metadata change for fromCache as well.
           // We comment this line out to reduce flakiness.
-
           // TODO(b/295872012): Figure out a way to check for all scenarios.
           // expect(snap.metadata.hasPendingWrites).to.be.false;
         });