Merge remote-tracking branch 'origin/master' into mila/BloomFilter

Author: dconeybe

.changeset/chilled-buckets-sneeze.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+'firebase': patch
+---
+
+Check navigator.userAgent, in addition to navigator.appVersion, when determining whether to work around an IndexedDb bug in Safari.

.changeset/fluffy-seas-behave.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Explicitly set createdAt and lastLoginAt when cloning UserImpl

packages/auth/demo/README.md

@@ -90,14 +90,22 @@ The demo page by default runs against the actual Auth Backend. To run against th
 yarn run demo:emulator
 ```
 
+## Running against Auth Staging endpoint
+
+Modify the configured endpoint to staging by following the changes in this branch:
+
+https://github.com/firebase/firebase-js-sdk/compare/use-staging
+
 ## Running against local changes to auth package
 
-By default, the demo runs against the latest release of firebase-auth sdk. This can be modified by:
+
+By default, the demo runs against the local firebase-auth implementation in packages/auth/src.
+This can be modified to point to a released version using:
 
 ```
 // packages/auth/demo/package.json
-+  "@firebase/auth": "file:..",
--  "@firebase/auth": "0.18.0",
+-  "@firebase/auth": "file:..",
++  "@firebase/auth": "0.18.0",
 ```
 
 ## Troubleshooting

packages/auth/demo/package.json

@@ -18,7 +18,7 @@
   },
   "dependencies": {
     "@firebase/app": "0.7.24",
-    "@firebase/auth": "0.20.1",
+    "@firebase/auth": "file:..",
     "@firebase/logger": "0.3.2",
     "@firebase/util": "1.6.0",
     "tslib": "^2.1.0"

packages/auth/src/core/user/user_impl.test.ts

@@ -274,7 +274,9 @@ describe('core/user/user_impl', () => {
             uid: 'i-am-uid'
           }
         ],
-        tenantId: 'tenant-id'
+        tenantId: 'tenant-id',
+        createdAt: '2018-01-01 13:02:56.12345678',
+        lastLoginAt: '2018-01-05 13:02:56.12345678'
       });
 
       const newAuth = await testAuth();
@@ -294,6 +296,7 @@ describe('core/user/user_impl', () => {
           uid: 'i-am-uid'
         }
       ]);
+      expect(copy.metadata.toJSON()).to.eql(user.metadata.toJSON());
     });
   });
 });

packages/auth/src/core/user/user_impl.ts

@@ -140,11 +140,13 @@ export class UserImpl implements UserInternal {
   }
 
   _clone(auth: AuthInternal): UserInternal {
-    return new UserImpl({
+    const newUser = new UserImpl({
       ...this,
       auth,
       stsTokenManager: this.stsTokenManager._clone()
     });
+    newUser.metadata._copy(this.metadata);
+    return newUser;
   }
 
   _onReload(callback: NextFn<APIUserInfo>): void {

packages/firestore-compat/test/fields.test.ts

@@ -387,8 +387,7 @@ apiDescribe('Timestamp Fields in snapshots', (persistence: boolean) => {
 });
 
 apiDescribe('`undefined` properties', (persistence: boolean) => {
-  const settings = { ...DEFAULT_SETTINGS };
-  settings.ignoreUndefinedProperties = true;
+  const settings = { ...DEFAULT_SETTINGS, ignoreUndefinedProperties: true };
 
   it('are ignored in set()', () => {
     return withTestDocAndSettings(persistence, settings, async doc => {

packages/firestore/src/local/indexeddb_persistence.ts

@@ -977,8 +977,13 @@ export class IndexedDbPersistence implements Persistence {
         // to make sure it gets a chance to run.
         this.markClientZombied();
 
-        if (isSafari() && navigator.appVersion.match(/Version\/1[45]/)) {
-          // On Safari 14 and 15, we do not run any cleanup actions as it might
+        const safariIndexdbBugVersionRegex = /(?:Version|Mobile)\/1[456]/;
+        if (
+          isSafari() &&
+          (navigator.appVersion.match(safariIndexdbBugVersionRegex) ||
+            navigator.userAgent.match(safariIndexdbBugVersionRegex))
+        ) {
+          // On Safari 14, 15, and 16, we do not run any cleanup actions as it might
           // trigger a bug that prevents Safari from re-opening IndexedDB during
           // the next page load.
           // See https://bugs.webkit.org/show_bug.cgi?id=226547