Adding no-unused-vars to TSLint (#493)

Author: schmidt-sebastian

packages/firestore/package.json

@@ -5,7 +5,8 @@
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "scripts": {
     "dev": "gulp dev",
-    "lint": "tslint -c tslint.json src/**/*.ts test/**/*.ts",
+    "lint": "tslint -p tsconfig.json -c tslint.json src/**/*.ts test/**/*.ts",
+    "lint:fix": "tslint --fix -p tsconfig.json -c tslint.json  src/**/*.ts test/**/*.ts",
     "test": "run-s lint test:all",
     "test:all": "run-p test:browser test:node",
     "test:browser": "karma start --single-run",

packages/firestore/src/api/credentials.ts

@@ -17,7 +17,6 @@
 import { User } from '../auth/user';
 import { assert, fail } from '../util/assert';
 import { Code, FirestoreError } from '../util/error';
-import { AnyJs } from '../util/misc';
 import { FirebaseApp } from '@firebase/app-types';
 import { _FirebaseApp } from '@firebase/app-types/private';
 

packages/firestore/src/api/database.ts

@@ -33,11 +33,7 @@ import {
   RelationOp
 } from '../core/query';
 import { Transaction as InternalTransaction } from '../core/transaction';
-import {
-  ChangeType,
-  DocumentViewChange,
-  ViewSnapshot
-} from '../core/view_snapshot';
+import { ChangeType, ViewSnapshot } from '../core/view_snapshot';
 import { Document, MaybeDocument, NoDocument } from '../model/document';
 import { DocumentKey } from '../model/document_key';
 import {

packages/firestore/src/api/user_data_converter.ts

@@ -14,8 +14,6 @@
  * limitations under the License.
  */
 
-import * as firestore from '@firebase/firestore-types';
-
 import { DatabaseId } from '../core/database_info';
 import { Timestamp } from '../core/timestamp';
 import { DocumentKey } from '../model/document_key';
@@ -248,13 +246,6 @@ class ParseContext {
       throw this.createError('Document fields cannot begin and end with __');
     }
   }
-
-  private isWrite(): boolean {
-    return (
-      this.dataSource === UserDataSource.Set ||
-      this.dataSource === UserDataSource.Update
-    );
-  }
 }
 /**
  * An interface that allows arbitrary pre-converting of user data. This

packages/firestore/src/core/event_manager.ts

@@ -22,7 +22,6 @@ import { ChangeType, ViewSnapshot } from './view_snapshot';
 import { DocumentSet } from '../model/document_set';
 import { assert } from '../util/assert';
 import { EventHandler } from '../util/misc';
-import * as obj from '../util/obj';
 import { ObjectMap } from '../util/obj_map';
 
 /**

packages/firestore/src/core/firestore_client.ts

@@ -274,7 +274,6 @@ export class FirestoreClient {
           this.databaseInfo.databaseId
         );
         const datastore = new Datastore(
-          this.databaseInfo,
           this.asyncQueue,
           connection,
           this.credentials,

packages/firestore/src/local/indexeddb_mutation_queue.ts

@@ -222,7 +222,6 @@ export class IndexedDbMutationQueue implements MutationQueue {
       .next(() => {
         const promises: Array<PersistencePromise<void>> = [];
         for (const mutation of mutations) {
-          const encodedPath = EncodedResourcePath.encode(mutation.key.path);
           const indexKey = DbDocumentMutation.key(
             this.userId,
             mutation.key.path,
@@ -379,7 +378,6 @@ export class IndexedDbMutationQueue implements MutationQueue {
       this.userId,
       queryPath
     );
-    const encodedQueryPath = indexPrefix[1];
     const indexStart = IDBKeyRange.lowerBound(indexPrefix);
 
     // Collect up unique batchIDs encountered during a scan of the index. Use a
@@ -516,8 +514,8 @@ export class IndexedDbMutationQueue implements MutationQueue {
     const startRange = IDBKeyRange.lowerBound(indexKey);
     let containsKey = false;
     return documentMutationsStore(txn)
-      .iterate({ range: startRange, keysOnly: true }, (key, _, control) => {
-        const [userID, keyPath, batchID] = key;
+      .iterate({ range: startRange, keysOnly: true }, (key, value, control) => {
+        const [userID, keyPath, /*batchID*/ _] = key;
         if (userID === this.userId && keyPath === encodedPath) {
           containsKey = true;
         }

packages/firestore/src/local/indexeddb_query_cache.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import * as api from '../protos/firestore_proto_api';
 import { Query } from '../core/query';
 import { SnapshotVersion } from '../core/snapshot_version';
 import { Timestamp } from '../core/timestamp';
@@ -27,7 +26,6 @@ import { immediateSuccessor } from '../util/misc';
 import * as EncodedResourcePath from './encoded_resource_path';
 import { GarbageCollector } from './garbage_collector';
 import {
-  DbQuery,
   DbTarget,
   DbTargetDocument,
   DbTargetDocumentKey,
@@ -237,7 +235,6 @@ export class IndexedDbQueryCache implements QueryCache {
     txn: PersistenceTransaction,
     targetId: TargetId
   ): PersistencePromise<DocumentKeySet> {
-    const promises: Array<PersistencePromise<void>> = [];
     const range = IDBKeyRange.bound(
       [targetId],
       [targetId + 1],

packages/firestore/src/local/memory_query_cache.ts

@@ -20,7 +20,6 @@ import { TargetId } from '../core/types';
 import { DocumentKeySet } from '../model/collections';
 import { DocumentKey } from '../model/document_key';
 import { ObjectMap } from '../util/obj_map';
-import { SortedSet } from '../util/sorted_set';
 
 import { GarbageCollector } from './garbage_collector';
 import { PersistenceTransaction } from './persistence';

packages/firestore/src/local/memory_remote_document_cache.ts

@@ -22,7 +22,6 @@ import {
 } from '../model/collections';
 import { Document, MaybeDocument } from '../model/document';
 import { DocumentKey } from '../model/document_key';
-import { DocumentSet } from '../model/document_set';
 
 import { PersistenceTransaction } from './persistence';
 import { PersistencePromise } from './persistence_promise';

packages/firestore/src/local/reference_set.ts

@@ -17,7 +17,6 @@
 import { BatchId, TargetId } from '../core/types';
 import { documentKeySet, DocumentKeySet } from '../model/collections';
 import { DocumentKey } from '../model/document_key';
-import { assert } from '../util/assert';
 import { primitiveComparator } from '../util/misc';
 import { SortedSet } from '../util/sorted_set';
 

packages/firestore/src/model/document_set.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { assert } from '../util/assert';
 import { SortedMap } from '../util/sorted_map';
 
 import { documentMap } from './collections';

packages/firestore/src/model/field_value.ts

@@ -20,10 +20,8 @@ import { SnapshotOptions } from '../api/database';
 import { DatabaseId } from '../core/database_info';
 import { Timestamp } from '../core/timestamp';
 import { assert, fail } from '../util/assert';
-import { AnyJs, primitiveComparator } from '../util/misc';
-import * as objUtils from '../util/obj';
+import { primitiveComparator } from '../util/misc';
 import { SortedMap } from '../util/sorted_map';
-import * as typeUtils from '../util/types';
 
 import { DocumentKey } from './document_key';
 import { FieldPath } from './path';

packages/firestore/src/platform/config.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import * as firestore from '@firebase/firestore-types';
 import { FirebaseApp, FirebaseNamespace } from '@firebase/app-types';
 import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { PublicBlob } from '../api/blob';

packages/firestore/src/platform_node/grpc_connection.ts

@@ -29,7 +29,6 @@ import { mapCodeFromRpcCode } from '../remote/rpc_error';
 import { assert } from '../util/assert';
 import { FirestoreError } from '../util/error';
 import * as log from '../util/log';
-import { AnyJs } from '../util/misc';
 import { NodeCallback, nodePromise } from '../util/node_api';
 import { Deferred } from '../util/promise';
 
@@ -45,7 +44,7 @@ const X_GOOG_API_CLIENT_VALUE = `gl-node/${process.versions.node} fire/${
 type DuplexRpc = () => grpc.ClientDuplexStream;
 type ReadableRpc<Req> = (req: Req) => grpc.ClientReadableStream;
 type UnaryRpc<Req, Resp> = (
-  req,
+  req: Req,
   callback: (err?: grpc.ServiceError, resp?: Resp) => void
 ) => grpc.ClientUnaryCall;
 

packages/firestore/src/remote/datastore.ts

@@ -16,7 +16,6 @@
 
 import * as api from '../protos/firestore_proto_api';
 import { CredentialsProvider } from '../api/credentials';
-import { DatabaseInfo } from '../core/database_info';
 import { maybeDocumentMap } from '../model/collections';
 import { MaybeDocument } from '../model/document';
 import { DocumentKey } from '../model/document_key';
@@ -27,9 +26,7 @@ import { AsyncQueue } from '../util/async_queue';
 import { Connection } from './connection';
 import {
   PersistentListenStream,
-  PersistentWriteStream,
-  WatchStreamListener,
-  WriteStreamListener
+  PersistentWriteStream
 } from './persistent_stream';
 import { JsonProtoSerializer } from './serializer';
 
@@ -50,7 +47,6 @@ interface CommitRequest extends api.CommitRequest {
  */
 export class Datastore {
   constructor(
-    private databaseInfo: DatabaseInfo,
     private queue: AsyncQueue,
     private connection: Connection,
     private credentials: CredentialsProvider,
@@ -60,7 +56,6 @@ export class Datastore {
 
   newPersistentWriteStream(): PersistentWriteStream {
     return new PersistentWriteStream(
-      this.databaseInfo,
       this.queue,
       this.connection,
       this.credentials,
@@ -71,7 +66,6 @@ export class Datastore {
 
   newPersistentWatchStream(): PersistentListenStream {
     return new PersistentListenStream(
-      this.databaseInfo,
       this.queue,
       this.connection,
       this.credentials,

packages/firestore/src/remote/persistent_stream.ts

@@ -16,7 +16,6 @@
 
 import * as api from '../protos/firestore_proto_api';
 import { CredentialsProvider, Token } from '../api/credentials';
-import { DatabaseInfo } from '../core/database_info';
 import { SnapshotVersion } from '../core/snapshot_version';
 import { ProtoByteString, TargetId } from '../core/types';
 import { QueryData } from '../local/query_data';
@@ -534,7 +533,6 @@ export class PersistentListenStream extends PersistentStream<
   WatchStreamListener
 > {
   constructor(
-    private databaseInfo: DatabaseInfo,
     queue: AsyncQueue,
     connection: Connection,
     credentials: CredentialsProvider,
@@ -638,7 +636,6 @@ export class PersistentWriteStream extends PersistentStream<
   private handshakeComplete_ = false;
 
   constructor(
-    private databaseInfo: DatabaseInfo,
     queue: AsyncQueue,
     connection: Connection,
     credentials: CredentialsProvider,

packages/firestore/src/remote/remote_store.ts

@@ -15,7 +15,6 @@
  */
 
 import { User } from '../auth/user';
-import { DatabaseInfo } from '../core/database_info';
 import { SnapshotVersion } from '../core/snapshot_version';
 import { Transaction } from '../core/transaction';
 import { BatchId, OnlineState, TargetId } from '../core/types';
@@ -31,7 +30,6 @@ import {
 } from '../model/mutation_batch';
 import { emptyByteString } from '../platform/platform';
 import { assert } from '../util/assert';
-import { AsyncQueue } from '../util/async_queue';
 import { Code, FirestoreError } from '../util/error';
 import * as log from '../util/log';
 import * as objUtils from '../util/obj';
@@ -291,7 +289,6 @@ export class RemoteStore {
       objUtils.contains(this.listenTargets, targetId),
       'unlisten called without assigned target ID!'
     );
-    const queryData = this.listenTargets[targetId];
     delete this.listenTargets[targetId];
     if (this.isNetworkEnabled() && this.watchStream.isOpen()) {
       this.sendUnwatchRequest(targetId);

packages/firestore/src/remote/stream_bridge.ts

@@ -16,7 +16,6 @@
 
 import { assert } from '../util/assert';
 import { FirestoreError } from '../util/error';
-import { AnyJs } from '../util/misc';
 
 import { Stream } from './connection';
 

packages/firestore/src/util/async_queue.ts

@@ -16,7 +16,7 @@
 
 import { assert, fail } from './assert';
 import * as log from './log';
-import { AnyDuringMigration, AnyJs } from './misc';
+import { AnyJs } from './misc';
 import { Deferred, CancelablePromise } from './promise';
 import { Code, FirestoreError } from './error';
 

packages/firestore/src/util/sorted_map.ts

@@ -485,7 +485,7 @@ export class LLRBNode<K, V> {
 
   // In a balanced RB tree, the black-depth (number of black nodes) from root to
   // leaves is equal on both sides.  This function verifies that or asserts.
-  private check(): number {
+  protected check(): number {
     if (this.isRed() && this.left.isRed()) {
       throw fail('Red node has red child(' + this.key + ',' + this.value + ')');
     }
@@ -562,7 +562,7 @@ export class LLRBEmptyNode<K, V> {
     return true;
   }
 
-  private check() {
+  protected check() {
     return 0;
   }
 } // end LLRBEmptyNode

packages/firestore/test/integration/api/type.test.ts

@@ -18,8 +18,11 @@ import { expect } from 'chai';
 import * as firestore from '@firebase/firestore-types';
 import firebase from '../util/firebase_export';
 import { apiDescribe, withTestDb, withTestDoc } from '../util/helpers';
+import { addEqualityMatcher } from '../../util/equality_matcher';
 
 apiDescribe('Firestore', persistence => {
+  addEqualityMatcher();
+
   function expectRoundtrip(
     db: firestore.FirebaseFirestore,
     data: {}

packages/firestore/test/integration/util/internal_helpers.ts

@@ -53,7 +53,6 @@ export function withTestDatastore(
         databaseInfo.databaseId
       );
       const datastore = new Datastore(
-        databaseInfo,
         queue || new AsyncQueue(),
         conn,
         new EmptyCredentialsProvider(),

packages/firestore/test/unit/model/mutation.test.ts

@@ -40,8 +40,11 @@ import {
   version,
   wrapObject
 } from '../../util/helpers';
+import { addEqualityMatcher } from '../../util/equality_matcher';
 
 describe('Mutation', () => {
+  addEqualityMatcher();
+
   const timestamp = Timestamp.now();
 
   it('can apply sets to documents', () => {

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -376,7 +376,6 @@ abstract class TestRunner {
     // Set backoff delay to 1ms so simulated disconnects don't delay the tests.
     const initialBackoffDelay = 1;
     this.datastore = new Datastore(
-      this.databaseInfo,
       this.queue,
       this.connection,
       new EmptyCredentialsProvider(),