Enable strict mode on all packages except firestore and database (#1948)

hsubox76 · web-flow · commit 444c3ae4b565 · 2019-07-15T10:33:13.000-07:00
diff --git a/config/tsconfig.base.json b/config/tsconfig.base.json
@@ -3,8 +3,7 @@
   "compilerOptions": {
     "declaration": true,
     "importHelpers": true,
-    "strictNullChecks": true,
-    "noImplicitAny": true,
+    "strict": true,
     "lib": [
       "es5",
       "dom",
diff --git a/packages/app/tsconfig.json b/packages/app/tsconfig.json
@@ -2,8 +2,7 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "resolveJsonModule": true,
-    "strict": true
+    "resolveJsonModule": true
   },
   "exclude": ["dist/**/*"]
 }
diff --git a/packages/database/tsconfig.json b/packages/database/tsconfig.json
@@ -2,8 +2,7 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "strictNullChecks": false,
-    "noImplicitAny": false
+    "strict": false
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/firebase/tsconfig.json b/packages/firebase/tsconfig.json
@@ -3,8 +3,7 @@
   "compilerOptions": {
     "outDir": "dist",
     "declaration": false,
-    "allowSyntheticDefaultImports": true,
-    "strict": true
+    "allowSyntheticDefaultImports": true
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/firestore/tsconfig.json b/packages/firestore/tsconfig.json
@@ -3,7 +3,12 @@
   "compilerOptions": {
     "outDir": "dist",
     "strictFunctionTypes": true,
-    "strictNullChecks": true
+    "strictNullChecks": true,
+    "noImplicitAny": true,
+    "alwaysStrict": false,
+    "noImplicitThis": false,
+    "strictBindCallApply": false,
+    "strictPropertyInitialization": false
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/functions/tsconfig.json b/packages/functions/tsconfig.json
@@ -1,8 +1,7 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "strict": true
+    "outDir": "dist"
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/installations/tsconfig.json b/packages/installations/tsconfig.json
@@ -3,8 +3,6 @@
   "compilerOptions": {
     "downlevelIteration": true,
     "resolveJsonModule": true,
-
-    "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
diff --git a/packages/logger/tsconfig.json b/packages/logger/tsconfig.json
@@ -1,8 +1,7 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "strict": true
+    "outDir": "dist"
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/messaging/tsconfig.json b/packages/messaging/tsconfig.json
@@ -2,7 +2,6 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "strict": true,
     "noUnusedLocals": true,
     "lib": [
       "dom",
diff --git a/packages/performance/tsconfig.json b/packages/performance/tsconfig.json
@@ -3,7 +3,6 @@
   "compilerOptions": {
     "outDir": "dist",
     "resolveJsonModule": true,
-    "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
diff --git a/packages/rxfire/firestore/collection/index.ts b/packages/rxfire/firestore/collection/index.ts
@@ -180,7 +180,10 @@ export function auditTrail(
   events?: firestore.DocumentChangeType[]
 ): Observable<firestore.DocumentChange[]> {
   return collectionChanges(query, events).pipe(
-    scan((current, action) => [...current, ...action], [])
+    scan(
+      (current, action) => [...current, ...action],
+      [] as firestore.DocumentChange[]
+    )
   );
 }
 
diff --git a/packages/storage/tsconfig.json b/packages/storage/tsconfig.json
@@ -1,8 +1,7 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "strict": true
+    "outDir": "dist"
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/testing/tsconfig.json b/packages/testing/tsconfig.json
@@ -1,8 +1,7 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "strict": true
+    "outDir": "dist"
   },
   "exclude": [
     "dist/**/*"
diff --git a/packages/util/tsconfig.json b/packages/util/tsconfig.json
@@ -1,8 +1,7 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "strict": true
+    "outDir": "dist"
   },
   "exclude": [
     "dist/**/*"
