add tests

Author: Feiyang1

packages/storage/src/platform/node/connection.ts

@@ -19,9 +19,6 @@ import { ErrorCode, Connection } from '../../implementation/connection';
 import { internalError } from '../../implementation/error';
 import nodeFetch, { FetchError } from 'node-fetch';
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-const fetch: typeof window.fetch = nodeFetch as any;
-
 /**
  * Network layer that works in Node.
  *
@@ -34,6 +31,8 @@ export class FetchConnection implements Connection {
   private body_: string | undefined;
   private headers_: Headers | undefined;
   private sent_: boolean = false;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  private fetch_: typeof window.fetch = nodeFetch as any;
 
   constructor() {
     this.errorCode_ = ErrorCode.NO_ERROR;
@@ -50,7 +49,7 @@ export class FetchConnection implements Connection {
     }
     this.sent_ = true;
 
-    return fetch(url, {
+    return this.fetch_(url, {
       method,
       headers: headers || {},
       body

packages/storage/test/browser/connection.test.ts

@@ -0,0 +1,17 @@
+import { expect } from "chai";
+import { SinonFakeXMLHttpRequest, useFakeXMLHttpRequest } from "sinon";
+import { ErrorCode } from "../../src/implementation/connection";
+import { XhrConnection } from "../../src/platform/browser/connection";
+
+describe('Connections', () => {
+    it('XhrConnection.send() should not reject on network errors', async () => {
+        const fakeXHR = useFakeXMLHttpRequest();
+        const connection = new XhrConnection();
+        const sendPromise = connection.send('testurl', 'GET');
+        // simulate an network error
+        ((connection as any).xhr_ as SinonFakeXMLHttpRequest).error();
+        await sendPromise;
+        expect(connection.getErrorCode()).to.equal(ErrorCode.NETWORK_ERROR);
+        fakeXHR.restore();
+    });
+});

packages/storage/test/unit/connection.test.ts

@@ -0,0 +1,15 @@
+import { stub } from 'sinon';
+import { expect } from 'chai';
+import { ErrorCode } from '../../src/implementation/connection';
+import { FetchConnection } from '../../src/platform/node/connection';
+
+describe('Connections', () => {
+    it('FetchConnection.send() should not reject on network errors', async () => {
+        const connection = new FetchConnection();
+
+        // need the casting here because fetch_ is a private member
+        stub(connection as any, 'fetch_').rejects();
+        await connection.send('testurl', 'GET');
+        expect(connection.getErrorCode()).to.equal(ErrorCode.NETWORK_ERROR);
+    });
+});