reverting linter changes in .test files

Author: bhparijat

packages/auth/demo/yarn.lock

@@ -54,10 +54,10 @@ function getTestFiles(argv) {
 }
 
 function getTestBrowsers(argv) {
-  let browsers = ['ChromeHeadless'];
+  let browsers = ["ChromeHeadless"]; 
   if (process.env?.BROWSERS && argv.unit) {
     browsers = process.env?.BROWSERS?.split(',');
-  }
+  } 
   return browsers;
 }
 

packages/auth/karma.conf.js

@@ -42,9 +42,7 @@ describe('core/util/_getClientVersion', () => {
     context('worker', () => {
       it('should set the correct version', () => {
         expect(_getClientVersion(ClientPlatform.WORKER)).to.eq(
-          `${_getBrowserName(
-            getUA()
-          )}-Worker/JsCore/${SDK_VERSION}/FirebaseCore-web`
+          `${_getBrowserName(getUA())}-Worker/JsCore/${SDK_VERSION}/FirebaseCore-web`
         );
       });
     });

packages/auth/src/core/util/version.test.ts

@@ -15,9 +15,8 @@
  * limitations under the License.
  */
 import { TotpSecret } from '../../platform_browser/mfa/assertions/totp';
-import { TotpMultiFactorAssertion } from '../../model/public_types';
+import { TotpMultiFactorAssertion, MultiFactorSession  } from '../../model/public_types';
 import { FactorId } from '../../model/enum_maps';
-import { MultiFactorSession } from '../../model/public_types';
 /**
  * Provider for generating a {@link TotpMultiFactorAssertion}.
  *
@@ -34,8 +33,8 @@ export class TotpMultiFactorGenerator {
    * {@link MultiFactorUser.enroll}.
    */
   static assertionForEnrollment(
-    secret: TotpSecret,
-    oneTimePassword: string
+    _secret: TotpSecret,
+    _oneTimePassword: string
   ): TotpMultiFactorAssertion {
     throw new Error('Unimplemented');
   }
@@ -49,8 +48,8 @@ export class TotpMultiFactorGenerator {
    * {@link MultiFactorResolver.resolveSignIn}.
    */
   static assertionForSignIn(
-    enrollmentId: string,
-    otp: string
+    _enrollmentId: string,
+    _otp: string
   ): TotpMultiFactorAssertion {
     throw new Error('Unimplemented');
   }
@@ -64,7 +63,7 @@ export class TotpMultiFactorGenerator {
    * @returns A promise to {@link TotpSecret}.
    */
   static async generateSecret(
-    session: MultiFactorSession
+    _session: MultiFactorSession
   ): Promise<TotpSecret> {
     throw new Error('Unimplemented');
   }

packages/auth/src/mfa/assertions/totp.ts

@@ -543,7 +543,8 @@ export interface AuthProvider {
  */
 export const enum FactorId {
   /** Phone as second factor */
-  PHONE = 'phone'
+  PHONE = 'phone',
+  TOTP = 'totp'
 }
 
 /**

packages/auth/src/model/public_types.ts

@@ -74,7 +74,7 @@ export class TotpSecret {
    * @returns A QRCode URL string.
    */
 
-  generateQrCodeUrl(accountName?: string, issuer?: string): string {
+  generateQrCodeUrl(_accountName?: string, issuer?: string): string {
     return null as any;
   }
 }

packages/auth/src/platform_browser/mfa/assertions/totp.ts

@@ -66,8 +66,8 @@ describe('platform_browser/persistence/session_storage', () => {
       afterEach(() => sinon.restore());
 
       it('should emit false if sessionStorage setItem throws', async () => {
-        sinon.stub(Storage.prototype, 'setItem').throws(new Error('nope'));
-        expect(await persistence._isAvailable()).to.be.false;
+      sinon.stub(Storage.prototype, 'setItem').throws(new Error('nope'));
+      expect(await persistence._isAvailable()).to.be.false;
       });
 
       it('should emit false if sessionStorage removeItem throws', async () => {

packages/auth/src/platform_browser/persistence/session_storage.test.ts

@@ -73,10 +73,8 @@ describe('platform_cordova/popup_redirect/events', () => {
       const spy = sinon.spy(Storage.prototype, 'setItem');
       const event = _generateNewEvent(auth, AuthEventType.REAUTH_VIA_REDIRECT);
       await _savePartialEvent(auth, event);
-      expect(spy).to.have.been.calledWith(
-        'firebase:authEvent:test-api-key:test-app',
-        JSON.stringify(event)
-      );
+      expect(spy).to.have.been.calledWith('firebase:authEvent:test-api-key:test-app',
+      JSON.stringify(event));
     });
   });