Skip to content

Commit 41f06be

Browse files
authored
Remove gcEnabled for multitab test (#7234)
1 parent 0a27d2f commit 41f06be

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

packages/firestore/test/unit/specs/limbo_spec.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ describeSpec('Limbo Documents:', [], () => {
425425
const docB = doc('collection/b', 1001, { key: 'b' });
426426
const deletedDocB = deletedDoc('collection/b', 1005);
427427

428-
return client(0, false)
428+
return client(0)
429429
.expectPrimaryState(true)
430430
.client(1)
431431
.userListens(query1)
@@ -463,7 +463,7 @@ describeSpec('Limbo Documents:', [], () => {
463463
const deletedDocB = deletedDoc('collection/b', 1006);
464464
const deletedDocC = deletedDoc('collection/c', 1008);
465465

466-
return client(0, false)
466+
return client(0)
467467
.expectPrimaryState(true)
468468
.userListens(query1)
469469
.watchAcksFull(query1, 1 * 1e6, docA, docB, docC)

packages/firestore/test/unit/specs/listen_spec.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,7 @@ describeSpec('Listens:', [], () => {
845845
const docA = doc('collection/a', 1000, { key: 'a' });
846846
const docB = doc('collection/b', 2000, { key: 'a' });
847847

848-
return client(0, /* withGcEnabled= */ false)
848+
return client(0)
849849
.becomeVisible()
850850
.client(1)
851851
.userListens(query1)
@@ -1754,7 +1754,7 @@ describeSpec('Listens:', [], () => {
17541754
() => {
17551755
const query1 = query('collection');
17561756
return (
1757-
client(0, /* withGcEnabled= */ false)
1757+
client(0)
17581758
// Populate the cache with the empty query results.
17591759
.userListens(query1)
17601760
.watchAcksFull(query1, 1000)
@@ -1785,7 +1785,7 @@ describeSpec('Listens:', [], () => {
17851785
const doc1Deleted = deletedDoc('collection/a', 2000);
17861786

17871787
return (
1788-
client(0, /* withGcEnabled= */ false)
1788+
client(0)
17891789
// Populate the cache with the empty query results.
17901790
.userListens(query1)
17911791
.watchAcksFull(query1, 1000, doc1)

packages/firestore/test/unit/specs/spec_builder.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -1252,10 +1252,7 @@ export function spec(): SpecBuilder {
12521252

12531253
/** Starts a new multi-client SpecTest. */
12541254
// PORTING NOTE: Only used by web multi-tab tests.
1255-
export function client(
1256-
num: number,
1257-
withGcEnabled?: boolean
1258-
): MultiClientSpecBuilder {
1255+
export function client(num: number): MultiClientSpecBuilder {
12591256
const specBuilder = new MultiClientSpecBuilder();
12601257
specBuilder.ensureManualLruGC();
12611258
return specBuilder.client(num);

0 commit comments

Comments
 (0)