Skip to content

Commit 3e56114

Browse files
authored
Merge 8fc79ff into c66d59c
2 parents c66d59c + 8fc79ff commit 3e56114

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.changeset/green-turtles-camp.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/database-compat': patch
3+
---
4+
5+
Remove app-compat from peerDependencies to avoid npm install warning in firebase-admin.

packages/database-compat/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@
4444
"test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
4545
"add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../database/dist/public.d.ts -o dist/database-compat/src/index.d.ts -a -r Database:types.FirebaseDatabase -r Query:types.Query -r DatabaseReference:types.Reference -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/database"
4646
},
47-
"peerDependencies": {
48-
"@firebase/app-compat": "0.x"
49-
},
5047
"dependencies": {
5148
"@firebase/database": "0.13.0",
5249
"@firebase/database-types": "0.9.8",

packages/database-compat/src/index.node.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17+
18+
// eslint-disable-next-line import/no-extraneous-dependencies
1719
import firebase from '@firebase/app-compat';
1820
import { FirebaseNamespace } from '@firebase/app-types';
1921
import { _FirebaseNamespace } from '@firebase/app-types/private';

0 commit comments

Comments
 (0)