Skip to content

Commit 3acbaaa

Browse files
committed
Address PR comments
1 parent 448c124 commit 3acbaaa

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

packages-exp/analytics-compat/src/constants.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
/**
1919
* Officially recommended event names for gtag.js
2020
* Any other string is also allowed.
21-
*
22-
* @public
2321
*/
2422
export enum EventName {
2523
ADD_SHIPPING_INFO = 'add_shipping_info',

packages-exp/analytics-compat/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ const factory: InstanceFactory<'analytics-compat'> = (
5858

5959
export function registerAnalytics(): void {
6060
const namespaceExports = {
61-
// no-inline
6261
Analytics: AnalyticsService,
6362
settings: settingsExp,
6463
isSupported: isSupportedExp,

packages-exp/functions-compat/src/register.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ const factory: InstanceFactory<'functions-compat'> = (
5353

5454
export function registerFunctions(): void {
5555
const namespaceExports = {
56-
// no-inline
5756
Functions: FunctionsService
5857
};
5958
(firebase as _FirebaseNamespace).INTERNAL.registerComponent(

0 commit comments

Comments
 (0)