Skip to content

Commit 384846b

Browse files
authored
Add installations import to analytics-exp (#4341)
1 parent b28aff2 commit 384846b

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

packages-exp/analytics-exp/rollup.config.js

+2-13
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,8 @@
1818
import json from '@rollup/plugin-json';
1919
import typescriptPlugin from 'rollup-plugin-typescript2';
2020
import typescript from 'typescript';
21-
import pkg from './package.json';
2221
import { es2017BuildsNoPlugin, es5BuildsNoPlugin } from './rollup.shared';
2322

24-
const deps = Object.keys(
25-
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
26-
);
27-
2823
/**
2924
* ES5 Builds
3025
*/
@@ -37,10 +32,7 @@ const es5BuildPlugins = [
3732

3833
const es5Builds = es5BuildsNoPlugin.map(build => ({
3934
...build,
40-
plugins: es5BuildPlugins,
41-
treeshake: {
42-
moduleSideEffects: false
43-
}
35+
plugins: es5BuildPlugins
4436
}));
4537

4638
/**
@@ -60,10 +52,7 @@ const es2017BuildPlugins = [
6052

6153
const es2017Builds = es2017BuildsNoPlugin.map(build => ({
6254
...build,
63-
plugins: es2017BuildPlugins,
64-
treeshake: {
65-
moduleSideEffects: false
66-
}
55+
plugins: es2017BuildPlugins
6756
}));
6857

6958
export default [...es5Builds, ...es2017Builds];

packages-exp/analytics-exp/rollup.config.release.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const es5Builds = es5BuildsNoPlugin.map(build => ({
3838
...build,
3939
plugins: es5BuildPlugins,
4040
treeshake: {
41-
moduleSideEffects: false
41+
moduleSideEffects: id => id === '@firebase/installations'
4242
}
4343
}));
4444

@@ -66,7 +66,7 @@ const es2017Builds = es2017BuildsNoPlugin.map(build => ({
6666
...build,
6767
plugins: es2017BuildPlugins,
6868
treeshake: {
69-
moduleSideEffects: false
69+
moduleSideEffects: id => id === '@firebase/installations'
7070
}
7171
}));
7272

packages-exp/analytics-exp/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import {
3838
Item,
3939
Promotion
4040
} from '@firebase/analytics-types-exp';
41+
import '@firebase/installations-exp';
4142

4243
declare global {
4344
interface Window {

0 commit comments

Comments
 (0)