Skip to content

Commit 370a24f

Browse files
committed
Add TODO comments
1 parent 5e7a3d1 commit 370a24f

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

packages/firestore/src/model/path.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ abstract class BasePath<B extends BasePath<B>> {
163163
return this.segments.slice(this.offset, this.limit());
164164
}
165165

166+
// TODO(Mila): Use database info and toString() to get full path instead.
166167
toFullPath(): string {
167168
return this.segments.join('/');
168169
}

packages/firestore/src/remote/watch_change.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -484,6 +484,7 @@ export class WatchChangeAggregator {
484484
return expectedCount === currentCount - removedDocumentCount;
485485
}
486486

487+
// TODO(Mila): Move the validation into normalizeByteString.
487488
private isValidBase64String(value: string): boolean {
488489
const regExp = new RegExp(
489490
'^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$'

0 commit comments

Comments
 (0)