Add TODO comments

milaGGL · milaGGL · commit 370a24f4d212 · 2023-01-25T16:01:51.000-08:00
diff --git a/packages/firestore/src/model/path.ts b/packages/firestore/src/model/path.ts
@@ -163,6 +163,7 @@ abstract class BasePath<B extends BasePath<B>> {
     return this.segments.slice(this.offset, this.limit());
   }
 
+  // TODO(Mila): Use database info and toString() to get full path instead.
   toFullPath(): string {
     return this.segments.join('/');
   }
diff --git a/packages/firestore/src/remote/watch_change.ts b/packages/firestore/src/remote/watch_change.ts
@@ -484,6 +484,7 @@ export class WatchChangeAggregator {
     return expectedCount === currentCount - removedDocumentCount;
   }
 
+  // TODO(Mila): Move the validation into normalizeByteString.
   private isValidBase64String(value: string): boolean {
     const regExp = new RegExp(
       '^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$'

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,7 @@ abstract class BasePath<B extends BasePath<B>> {`
`163`	`163`	`return this.segments.slice(this.offset, this.limit());`
`164`	`164`	`}`
`165`	`165`
	`166`	`+ // TODO(Mila): Use database info and toString() to get full path instead.`
`166`	`167`	`toFullPath(): string {`
`167`	`168`	`return this.segments.join('/');`
`168`	`169`	`}`
Original file line number	Diff line number	Diff line change
`@@ -484,6 +484,7 @@ export class WatchChangeAggregator {`
`484`	`484`	`return expectedCount === currentCount - removedDocumentCount;`
`485`	`485`	`}`
`486`	`486`
	`487`	`+ // TODO(Mila): Move the validation into normalizeByteString.`
`487`	`488`	`private isValidBase64String(value: string): boolean {`
`488`	`489`	`const regExp = new RegExp(`
`489`	`490`	`'^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==\|[A-Za-z0-9+/]{3}=)?$'`