Add app-compat hack (#4036)

Author: hsubox76

packages/firestore/package.json

@@ -79,7 +79,6 @@
   },
   "devDependencies": {
     "@firebase/app": "0.6.12",
-    "@firebase/app-compat": "0.x",
     "@rollup/plugin-alias": "3.1.1",
     "@types/json-stable-stringify": "1.0.32",
     "json-stable-stringify": "1.0.1",

scripts/ci-test/build_changed.ts

@@ -29,12 +29,18 @@ const argv = yargs.options({
     type: 'boolean',
     desc:
       'whether or not build @firebase/app-exp first. It is a hack required to build Firestore'
+  },
+  buildAppCompat: {
+    type: 'boolean',
+    desc:
+      'whether or not build @firebase/app-compat first. It is a hack required to build Firestore'
   }
 }).argv;
 
 const allTestConfigNames = Object.keys(testConfig);
 const inputTestConfigName = argv._[0];
 const buildAppExp = argv.buildAppExp;
+const buildAppCompat = argv.buildAppCompat;
 
 if (!inputTestConfigName) {
   throw Error(`
@@ -82,6 +88,23 @@ async function buildForTests(config: TestConfig, buildAppExp = false) {
         { stdio: 'inherit', cwd: root }
       );
     }
+    // hack to build Firestore which depends on @firebase/app-exp (because of firestore exp),
+    // but doesn't list it as a dependency in its package.json
+    // TODO: remove once modular SDKs become official
+    if (buildAppCompat) {
+      await spawn(
+        'npx',
+        [
+          'lerna',
+          'run',
+          '--scope',
+          '@firebase/app-compat',
+          '--include-dependencies',
+          'build'
+        ],
+        { stdio: 'inherit', cwd: root }
+      );
+    }
 
     const lernaCmd = ['lerna', 'run'];
     console.log(chalk`{blue Running build in:}`);