Fixing the tests

Author: schmidt-sebastian

packages/firestore/src/local/indexeddb_persistence.ts

@@ -26,7 +26,7 @@ import { IndexedDbMutationQueue } from './indexeddb_mutation_queue';
 import { IndexedDbQueryCache } from './indexeddb_query_cache';
 import { IndexedDbRemoteDocumentCache } from './indexeddb_remote_document_cache';
 import {
-  ALL_STORES,
+  DEFAULT_STORES,
   createOrUpgradeDb,
   DbOwner,
   DbOwnerKey,
@@ -181,7 +181,7 @@ export class IndexedDbPersistence implements Persistence {
 
     // Do all transactions as readwrite against all object stores, since we
     // are the only reader/writer.
-    return this.simpleDb.runTransaction('readwrite', ALL_STORES, txn => {
+    return this.simpleDb.runTransaction('readwrite', DEFAULT_STORES, txn => {
       // Verify that we still have the owner lease as part of every transaction.
       return this.ensureOwnerLease(txn).next(() => operation(txn));
     });

packages/firestore/src/local/indexeddb_schema.ts

@@ -563,8 +563,7 @@ function createClientMetadataStore(db: IDBDatabase): void {
   });
 }
 
-// Exported for testing.
-export const V1_STORES = [
+const V1_STORES = [
   DbMutationQueue.store,
   DbMutationBatch.store,
   DbDocumentMutation.store,
@@ -578,7 +577,13 @@ export const V1_STORES = [
 const V2_STORES = [DbClientMetadata.store, DbTargetChange.store];
 
 /**
- * The list of all IndexedDB stores used by the SDK. This is used when creating
- * transactions so that access across all stores is done atomically.
+ * The list of all default IndexedDB stores used by the SDK. This is used when
+ * creating transactions so that access across all stores is done atomically.
+ */
+export const DEFAULT_STORES = V1_STORES;
+
+/**
+ * The list of all IndexedDb stores. This is only available in clients with
+ * the schema version 2.
  */
 export const ALL_STORES = [...V1_STORES, ...V2_STORES];

packages/firestore/test/unit/local/schema_migration.test.ts

@@ -17,9 +17,9 @@
 import { expect } from 'chai';
 import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
 import {
-  ALL_STORES,
+  DEFAULT_STORES,
   createOrUpgradeDb,
-  V1_STORES
+  ALL_STORES
 } from '../../../src/local/indexeddb_schema';
 import { Deferred } from '../../../src/util/promise';
 import { SimpleDb } from '../../../src/local/simple_db';
@@ -67,7 +67,7 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
   it('can install schema version 1', () => {
     return initDb(1).then(db => {
       expect(db.version).to.be.equal(1);
-      expect(getAllObjectStores(db)).to.have.members(V1_STORES);
+      expect(getAllObjectStores(db)).to.have.members(DEFAULT_STORES);
     });
   });