Skip to content

Commit 31d8863

Browse files
committed
resolve comments
1 parent d73e041 commit 31d8863

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

packages/firestore/src/local/target_data.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ export class TargetData {
6969
readonly resumeToken: ByteString = ByteString.EMPTY_BYTE_STRING,
7070
/**
7171
* The number of documents that last matched the query at the resume token or
72-
* read time.
72+
* read time. Documents are counted only when making a listen request with
73+
* resume token or read time, otherwise, keep it null.
7374
*/
7475
readonly expectedCount: number | null = null
7576
) {}
@@ -104,7 +105,7 @@ export class TargetData {
104105
snapshotVersion,
105106
this.lastLimboFreeSnapshotVersion,
106107
resumeToken,
107-
/** expectedCount= */ null
108+
/* expectedCount= */ null
108109
);
109110
}
110111

packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1826,7 +1826,7 @@ describeSpec('Listens:', [], () => {
18261826
.expectEvents(query1, {})
18271827
.userUnlistens(query1)
18281828
.watchRemoves(query1)
1829-
// There is 0 remote document from previous listen.
1829+
// There are 0 remote documents from previous listen.
18301830
.userListens(query1, {
18311831
resumeToken: 'resume-token-1000',
18321832
expectedCount: 0
@@ -1888,7 +1888,7 @@ describeSpec('Listens:', [], () => {
18881888
.disableNetwork()
18891889
.expectEvents(query1, { fromCache: true })
18901890
.enableNetwork()
1891-
.restoreListen(query1, 'resume-token-1000', 1);
1891+
.restoreListen(query1, 'resume-token-1000', /* expectedCount= */ 1);
18921892
}
18931893
);
18941894
});

packages/firestore/test/unit/specs/spec_builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,7 @@ export class SpecBuilder {
10961096
resume?: ResumeSpec
10971097
): void {
10981098
if (!(resume?.resumeToken || resume?.readTime) && resume?.expectedCount) {
1099-
fail('ExpectedCount is present without a resumeToken or readTime.');
1099+
fail('Expected count is present without a resume token or read time.');
11001100
}
11011101

11021102
if (this.activeTargets[targetId]) {

0 commit comments

Comments
 (0)