cleanup

Author: Feiyang1

packages/storage-compat/.eslintrc.js

@@ -26,7 +26,6 @@ module.exports = {
     tsconfigRootDir: __dirname
   },
   rules: {
-    'no-throw-literal': 'off',
     '@typescript-eslint/no-unused-vars': [
       'error',
       {

packages/storage-compat/package.json

@@ -36,6 +36,7 @@
     "tslib": "^2.1.0"
   },
   "devDependencies": {
+    "@firebase/app-compat": "0.x",
     "rollup": "2.52.2",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.30.0",

packages/storage/.eslintrc.js

@@ -26,23 +26,12 @@ module.exports = {
     tsconfigRootDir: __dirname
   },
   rules: {
-    'no-throw-literal': 'off',
     '@typescript-eslint/no-unused-vars': [
       'error',
       {
         varsIgnorePattern: '^_',
         args: 'none'
       }
-    ],
-    'import/no-extraneous-dependencies': [
-      'error',
-      {
-        'packageDir': [
-          path.resolve(__dirname, '../../'),
-          __dirname,
-          path.resolve(__dirname, 'exp')
-        ]
-      }
     ]
   }
 };

packages/storage/.npmignore

@@ -34,14 +34,6 @@ function getTestFiles(argv) {
   let unitTestFiles = ['test/unit/*'];
   let integrationTestFiles = ['test/integration/*'];
 
-  // if (argv.compat) {
-  //   unitTestFiles = unitTestFiles.filter(
-  //     filename => !filename.includes('.exp.')
-  //   );
-  //   integrationTestFiles = ['test/integration/*compat*'];
-  // } else {
-  //   integrationTestFiles = ['test/integration/*'];
-  // }
   if (argv.unit) {
     return unitTestFiles;
   } else if (argv.integration) {

packages/storage/karma.conf.js

@@ -8,8 +8,7 @@
   "browser": "dist/index.esm2017.js",
   "esm5": "dist/index.esm5.js",
   "files": [
-    "dist",
-    "exp/dist"
+    "dist"
   ],
   "scripts": {
     "bundle": "rollup -c",
@@ -20,12 +19,8 @@
     "dev": "rollup -c -w",
     "test": "run-p test:browser test:node lint",
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser test:node",
-    "test:browser:compat:unit": "karma start --single-run --compat --unit",
-    "test:browser:exp:unit": "karma start --single-run --exp --unit",
-    "test:browser:compat:integration": "karma start --single-run --compat --integration",
-    "test:browser:exp:integration": "karma start --single-run --exp --integration",
-    "test:browser:compat": "karma start --single-run --compat",
-    "test:browser:exp": "karma start --single-run --exp",
+    "test:browser:unit": "karma start --single-run --unit",
+    "test:browser:integration": "karma start --single-run --integration",
     "test:browser": "karma start --single-run",
     "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.ts --config ../../config/mocharc.node.js",
     "test:debug": "karma start --browser=Chrome",
@@ -34,7 +29,6 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@firebase/storage-types": "0.4.1",
     "@firebase/util": "1.2.0",
     "@firebase/component": "0.5.5",
     "node-fetch": "2.6.1",