Skip to content

Commit 307ca6c

Browse files
committed
cleanup
1 parent 56aa473 commit 307ca6c

File tree

6 files changed

+4
-38
lines changed

6 files changed

+4
-38
lines changed

packages/storage-compat/.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ module.exports = {
2626
tsconfigRootDir: __dirname
2727
},
2828
rules: {
29-
'no-throw-literal': 'off',
3029
'@typescript-eslint/no-unused-vars': [
3130
'error',
3231
{

packages/storage-compat/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
"tslib": "^2.1.0"
3737
},
3838
"devDependencies": {
39+
"@firebase/app-compat": "0.x",
3940
"rollup": "2.52.2",
4041
"@rollup/plugin-json": "4.1.0",
4142
"rollup-plugin-typescript2": "0.30.0",

packages/storage/.eslintrc.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,12 @@ module.exports = {
2626
tsconfigRootDir: __dirname
2727
},
2828
rules: {
29-
'no-throw-literal': 'off',
3029
'@typescript-eslint/no-unused-vars': [
3130
'error',
3231
{
3332
varsIgnorePattern: '^_',
3433
args: 'none'
3534
}
36-
],
37-
'import/no-extraneous-dependencies': [
38-
'error',
39-
{
40-
'packageDir': [
41-
path.resolve(__dirname, '../../'),
42-
__dirname,
43-
path.resolve(__dirname, 'exp')
44-
]
45-
}
4635
]
4736
}
4837
};

packages/storage/.npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/storage/karma.conf.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@ function getTestFiles(argv) {
3434
let unitTestFiles = ['test/unit/*'];
3535
let integrationTestFiles = ['test/integration/*'];
3636

37-
// if (argv.compat) {
38-
// unitTestFiles = unitTestFiles.filter(
39-
// filename => !filename.includes('.exp.')
40-
// );
41-
// integrationTestFiles = ['test/integration/*compat*'];
42-
// } else {
43-
// integrationTestFiles = ['test/integration/*'];
44-
// }
4537
if (argv.unit) {
4638
return unitTestFiles;
4739
} else if (argv.integration) {

packages/storage/package.json

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
"browser": "dist/index.esm2017.js",
99
"esm5": "dist/index.esm5.js",
1010
"files": [
11-
"dist",
12-
"exp/dist"
11+
"dist"
1312
],
1413
"scripts": {
1514
"bundle": "rollup -c",
@@ -20,12 +19,8 @@
2019
"dev": "rollup -c -w",
2120
"test": "run-p test:browser test:node lint",
2221
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser test:node",
23-
"test:browser:compat:unit": "karma start --single-run --compat --unit",
24-
"test:browser:exp:unit": "karma start --single-run --exp --unit",
25-
"test:browser:compat:integration": "karma start --single-run --compat --integration",
26-
"test:browser:exp:integration": "karma start --single-run --exp --integration",
27-
"test:browser:compat": "karma start --single-run --compat",
28-
"test:browser:exp": "karma start --single-run --exp",
22+
"test:browser:unit": "karma start --single-run --unit",
23+
"test:browser:integration": "karma start --single-run --integration",
2924
"test:browser": "karma start --single-run",
3025
"test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.ts --config ../../config/mocharc.node.js",
3126
"test:debug": "karma start --browser=Chrome",
@@ -34,7 +29,6 @@
3429
},
3530
"license": "Apache-2.0",
3631
"dependencies": {
37-
"@firebase/storage-types": "0.4.1",
3832
"@firebase/util": "1.2.0",
3933
"@firebase/component": "0.5.5",
4034
"node-fetch": "2.6.1",

0 commit comments

Comments
 (0)