Skip to content

Commit 3020f96

Browse files
committed
fix typescript errors
1 parent e19835e commit 3020f96

File tree

4 files changed

+27
-0
lines changed

4 files changed

+27
-0
lines changed

packages/firestore/test/integration/api/query.test.ts

+22
Original file line numberDiff line numberDiff line change
@@ -706,8 +706,11 @@ apiDescribe('Queries', (persistence: boolean) => {
706706

707707
await withTestCollection(persistence, testDocs, async coll => {
708708
let expected = { ...testDocs };
709+
// @ts-expect-error
709710
delete expected.a;
711+
// @ts-expect-error
710712
delete expected.h;
713+
// @ts-expect-error
711714
delete expected.i;
712715
const snapshot = await coll.where('zip', notEqualOp, 98101).get();
713716
expect(toDataArray(snapshot)).to.have.deep.members(
@@ -719,8 +722,11 @@ apiDescribe('Queries', (persistence: boolean) => {
719722
.where('zip', notEqualOp, { code: 500 })
720723
.get();
721724
expected = { ...testDocs };
725+
// @ts-expect-error
722726
delete expected.f;
727+
// @ts-expect-error
723728
delete expected.h;
729+
// @ts-expect-error
724730
delete expected.i;
725731
expect(toDataArray(snapshot2)).to.have.deep.members(
726732
Object.values(expected)
@@ -729,7 +735,9 @@ apiDescribe('Queries', (persistence: boolean) => {
729735
// With null.
730736
const snapshot3 = await coll.where('zip', notEqualOp, null).get();
731737
expected = { ...testDocs };
738+
// @ts-expect-error
732739
delete expected.h;
740+
// @ts-expect-error
733741
delete expected.i;
734742
expect(toDataArray(snapshot3)).to.have.deep.members(
735743
Object.values(expected)
@@ -738,8 +746,11 @@ apiDescribe('Queries', (persistence: boolean) => {
738746
// With NaN.
739747
const snapshot4 = await coll.where('zip', notEqualOp, Number.NaN).get();
740748
expected = { ...testDocs };
749+
// @ts-expect-error
741750
delete expected.h;
751+
// @ts-expect-error
742752
delete expected.i;
753+
// @ts-expect-error
743754
delete expected.j;
744755
expect(toDataArray(snapshot4)).to.have.deep.members(
745756
Object.values(expected)
@@ -859,9 +870,13 @@ apiDescribe('Queries', (persistence: boolean) => {
859870

860871
await withTestCollection(persistence, testDocs, async coll => {
861872
let expected = { ...testDocs };
873+
// @ts-expect-error
862874
delete expected.a;
875+
// @ts-expect-error
863876
delete expected.c;
877+
// @ts-expect-error
864878
delete expected.g;
879+
// @ts-expect-error
865880
delete expected.h;
866881
const snapshot = await coll
867882
.where('zip', notInOp, [98101, 98103, [98101, 98102]])
@@ -873,7 +888,9 @@ apiDescribe('Queries', (persistence: boolean) => {
873888
.where('zip', notInOp, [{ code: 500 }])
874889
.get();
875890
expected = { ...testDocs };
891+
// @ts-expect-error
876892
delete expected.f;
893+
// @ts-expect-error
877894
delete expected.h;
878895
expect(toDataArray(snapshot2)).to.deep.equal(Object.values(expected));
879896

@@ -884,7 +901,9 @@ apiDescribe('Queries', (persistence: boolean) => {
884901
// With NaN.
885902
const snapshot4 = await coll.where('zip', notInOp, [Number.NaN]).get();
886903
expected = { ...testDocs };
904+
// @ts-expect-error
887905
delete expected.h;
906+
// @ts-expect-error
888907
delete expected.j;
889908
expect(toDataArray(snapshot4)).to.deep.equal(Object.values(expected));
890909

@@ -893,8 +912,11 @@ apiDescribe('Queries', (persistence: boolean) => {
893912
.where('zip', notInOp, [Number.NaN, 98101])
894913
.get();
895914
expected = { ...testDocs };
915+
// @ts-expect-error
896916
delete expected.a;
917+
// @ts-expect-error
897918
delete expected.h;
919+
// @ts-expect-error
898920
delete expected.j;
899921
expect(toDataArray(snapshot5)).to.deep.equal(Object.values(expected));
900922
});

packages/installations/src/helpers/extract-app-config.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,12 @@ describe('extractAppConfig', () => {
3838
expect(() => extractAppConfig(undefined as any)).to.throw(FirebaseError);
3939

4040
let firebaseApp = getFakeApp();
41+
// @ts-expect-error
4142
delete firebaseApp.name;
4243
expect(() => extractAppConfig(firebaseApp)).to.throw(FirebaseError);
4344

4445
firebaseApp = getFakeApp();
46+
// @ts-expect-error
4547
delete firebaseApp.options;
4648
expect(() => extractAppConfig(firebaseApp)).to.throw(FirebaseError);
4749

packages/messaging/src/helpers/extract-app-config.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,14 @@ describe('extractAppConfig', () => {
4242
).to.throw('Missing App configuration value: "App Configuration Object"');
4343

4444
let firebaseApp = getFakeApp();
45+
// @ts-expect-error
4546
delete firebaseApp.options;
4647
expect(() => extractAppConfig(firebaseApp)).to.throw(
4748
'Missing App configuration value: "App Configuration Object"'
4849
);
4950

5051
firebaseApp = getFakeApp();
52+
// @ts-expect-error
5153
delete firebaseApp.name;
5254
expect(() => extractAppConfig(firebaseApp)).to.throw(
5355
'Missing App configuration value: "App Name"'

repo-scripts/size-analysis/analysis-helper.ts

+1
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,7 @@ export function buildMap(api: MemberList): Map<string, string> {
801801
*/
802802
async function traverseDirs(
803803
moduleLocation: string,
804+
// eslint-disable-next-line @typescript-eslint/ban-types
804805
executor: Function,
805806
level: number,
806807
levelLimit: number

0 commit comments

Comments
 (0)