Make offline warning an error instead of debug. (#379)

zxu123 · web-flow · commit 2fa51d3b4570 · 2017-12-13T16:15:41.000-05:00
* make offline warning an `error` instead of `debug`

By default, debug is not shown. We actually want the default behavior to show offline warning, if offline.

* not using tag in `log.error`
diff --git a/packages/firestore/src/remote/remote_store.ts b/packages/firestore/src/remote/remote_store.ts
@@ -192,7 +192,7 @@ export class RemoteStore {
       this.watchStreamFailures++;
       if (this.watchStreamFailures >= ONLINE_ATTEMPTS_BEFORE_FAILURE) {
         if (this.shouldWarnOffline) {
-          log.debug(LOG_TAG, 'Could not reach Firestore backend.');
+          log.error('Could not reach Firestore backend.');
           this.shouldWarnOffline = false;
         }
         this.updateOnlineState(OnlineState.Failed);

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ export class RemoteStore {`
`192`	`192`	`this.watchStreamFailures++;`
`193`	`193`	`if (this.watchStreamFailures >= ONLINE_ATTEMPTS_BEFORE_FAILURE) {`
`194`	`194`	`if (this.shouldWarnOffline) {`
`195`		`- log.debug(LOG_TAG, 'Could not reach Firestore backend.');`
	`195`	`+ log.error('Could not reach Firestore backend.');`
`196`	`196`	`this.shouldWarnOffline = false;`
`197`	`197`	`}`
`198`	`198`	`this.updateOnlineState(OnlineState.Failed);`