WIP

Author: schmidt-sebastian

packages/firestore/index.console.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export { Firestore, FirestoreDatabase } from './src/api/database';
+export { Firestore } from './src/api/database';
 export {
   CollectionReference,
   DocumentReference,
@@ -24,7 +24,6 @@ export {
 } from './src/api/database';
 export { Blob } from './src/api/blob';
 export { GeoPoint } from './src/api/geo_point';
-export { FirstPartyCredentialsSettings } from './src/api/credentials';
 export { FieldPath } from './src/api/field_path';
 export { FieldValue } from './src/api/field_value';
 export { Timestamp } from './src/api/timestamp';

packages/firestore/rollup.shared.js

@@ -175,8 +175,10 @@ exports.es2017ToEs5Plugins = function (mangled = false) {
     return [
       typescriptPlugin({
         typescript,
-        compilerOptions: {
-          allowJs: true
+        tsconfigOverride: {
+          compilerOptions: {
+            allowJs: true
+          }
         },
         include: ['dist/*.js', 'dist/exp/*.js']
       }),
@@ -193,8 +195,10 @@ exports.es2017ToEs5Plugins = function (mangled = false) {
     return [
       typescriptPlugin({
         typescript,
-        compilerOptions: {
-          allowJs: true
+        tsconfigOverride: {
+          compilerOptions: {
+            allowJs: true
+          }
         },
         include: ['dist/*.js', 'dist/exp/*.js']
       }),

packages/firestore/src/api/credentials.ts

@@ -29,14 +29,16 @@ import { logDebug } from '../util/log';
 // moved to an auth/ folder to match other platforms.
 
 export interface FirstPartyCredentialsSettings {
-  type: 'gapi';
-  client: unknown;
-  sessionIndex: string;
+  // These are external types. Prevent minification.
+  ['type']: 'gapi';
+  ['client']: unknown;
+  ['sessionIndex']: string;
 }
 
 export interface ProviderCredentialsSettings {
-  type: 'provider';
-  client: CredentialsProvider;
+  // These are external types. Prevent minification.
+  ['type']: 'provider';
+  ['client']: CredentialsProvider;
 }
 
 /** Settings for private credentials */
@@ -336,9 +338,9 @@ export function makeCredentialsProvider(
     return new EmptyCredentialsProvider();
   }
 
-  switch (credentials.type) {
+  switch (credentials['type']) {
     case 'gapi':
-      const client = credentials.client as Gapi;
+      const client = credentials['client'] as Gapi;
       // Make sure this really is a Gapi client.
       hardAssert(
         !!(
@@ -351,11 +353,11 @@ export function makeCredentialsProvider(
       );
       return new FirstPartyCredentialsProvider(
         client,
-        credentials.sessionIndex || '0'
+        credentials['sessionIndex'] || '0'
       );
 
     case 'provider':
-      return credentials.client;
+      return credentials['client'];
 
     default:
       throw new FirestoreError(

packages/firestore/tools/console.build.js

@@ -19,8 +19,8 @@
  * Firebase console uses firestore in its special way.
  * This file creates a build target for it.
  */
-const tmp = require('tmp');
 const rollup = require('rollup');
+const { uglify } = require('rollup-plugin-uglify');
 const fs = require('fs');
 const util = require('util');
 const fs_writeFile = util.promisify(fs.writeFile);
@@ -29,35 +29,43 @@ const rollupUtil = require('../rollup.shared');
 
 const EXPORTNAME = '__firestore_exports__';
 
-const tmpFile = tmp.fileSync().name;
+const esm2017OutputFile = 'dist/standalone.esm2017.js';
+const esm5OutputFile = 'dist/standalone.js';
 
 const es2017InputOptions = {
   input: 'index.console.ts',
   // If I set mangled to true the build breaks, but all other build pipelines
   // use the same settings
-  plugins: rollupUtil.es2017Plugins('browser', /* mangled= */ false),
+  plugins: rollupUtil.es2017Plugins('browser', /* mangled= */ true),
   external: rollupUtil.resolveBrowserExterns,
   treeshake: {
     moduleSideEffects: false
   }
 };
 
 const es2017OutputOptions = {
-  file: tmpFile,
+  file: esm2017OutputFile,
   format: 'es'
 };
 
 const es2017toEs5InputOptions = {
-  input: tmpFile,
-  plugins: rollupUtil.es2017ToEs5Plugins(/* mangled= */ true),
+  input: esm2017OutputFile,
+  plugins: [
+    ...rollupUtil.es2017ToEs5Plugins(/* mangled= */ true),
+    uglify({
+      output: {
+        ascii_only: true // escape unicode chars
+      }
+    })
+  ],
   external: rollupUtil.resolveBrowserExterns,
   treeshake: {
     moduleSideEffects: false
   }
 };
 
 const es2017toEs5OutputOptions = {
-  file: 'dist/standalone.js',
+  file: esm5OutputFile,
   name: EXPORTNAME,
   format: 'iife'
 };
@@ -72,7 +80,6 @@ async function build() {
   // create an ES2017 bundle
   const es2017Bundle = await rollup.rollup(es2017InputOptions);
   await es2017Bundle.write(es2017OutputOptions);
-  console.log(tmpFile);
 
   const es5Bundle = await rollup.rollup(es2017toEs5InputOptions);
   const {