Skip to content

Commit 2b68768

Browse files
committed
make database types compatible
1 parent 9858dc5 commit 2b68768

File tree

2 files changed

+22
-47
lines changed

2 files changed

+22
-47
lines changed

integration/compat-typings/typings.ts

+21-46
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import {
3535
FirebaseStorage,
3636
Reference as StorageReference
3737
} from '@firebase/storage-types';
38+
import { FirebaseDatabase, Reference, Query } from '@firebase/database-types';
3839

3940
/**
4041
* Test namespaced types from compat/index.d.ts against the types used in
@@ -45,38 +46,6 @@ import {
4546
* - app-compat, which defines its FirebaseApp type in its own package
4647
*/
4748

48-
const namespaced: {
49-
auth: firebase.auth.Auth;
50-
analytics: firebase.analytics.Analytics;
51-
app: firebase.app.App;
52-
firestore: firebase.firestore.Firestore;
53-
functions: firebase.functions.Functions;
54-
installations?: firebase.installations.Installations;
55-
messaging: firebase.messaging.Messaging;
56-
performance: firebase.performance.Performance;
57-
remoteConfig: firebase.remoteConfig.RemoteConfig;
58-
storage: firebase.storage.Storage;
59-
storageReference: firebase.storage.Reference;
60-
firestoreDocumentReference: firebase.firestore.DocumentReference;
61-
firestoreCollectionReference: firebase.firestore.CollectionReference;
62-
authUser: firebase.User;
63-
} = {
64-
auth: firebase.auth(),
65-
analytics: firebase.analytics(),
66-
app: firebase.initializeApp({}),
67-
firestore: firebase.firestore(),
68-
functions: firebase.functions(),
69-
installations: {} as firebase.installations.Installations,
70-
messaging: firebase.messaging(),
71-
performance: firebase.performance(),
72-
remoteConfig: firebase.remoteConfig(),
73-
storage: firebase.storage(),
74-
storageReference: {} as firebase.storage.Reference,
75-
firestoreDocumentReference: {} as firebase.firestore.DocumentReference,
76-
firestoreCollectionReference: {} as firebase.firestore.CollectionReference,
77-
authUser: {} as firebase.User
78-
};
79-
8049
const compatTypes: {
8150
auth: FirebaseAuth;
8251
analytics: FirebaseAnalytics;
@@ -92,19 +61,25 @@ const compatTypes: {
9261
firestoreDocumentReference: DocumentReference;
9362
firestoreCollectionReference: CollectionReference;
9463
authUser: User;
64+
database: FirebaseDatabase;
65+
databaseReference: Reference;
66+
databaseQuery: Query;
9567
} = {
96-
auth: namespaced.auth,
97-
analytics: namespaced.analytics,
98-
app: namespaced.app,
99-
firestore: namespaced.firestore,
100-
functions: namespaced.functions,
101-
installations: namespaced.installations,
102-
messaging: namespaced.messaging,
103-
performance: namespaced.performance,
104-
remoteConfig: namespaced.remoteConfig,
105-
storage: namespaced.storage,
106-
storageReference: namespaced.storageReference,
107-
firestoreDocumentReference: namespaced.firestoreDocumentReference,
108-
firestoreCollectionReference: namespaced.firestoreCollectionReference,
109-
authUser: namespaced.authUser
68+
auth: firebase.auth(),
69+
analytics: firebase.analytics(),
70+
app: firebase.initializeApp({}),
71+
firestore: firebase.firestore(),
72+
functions: firebase.functions(),
73+
installations: {} as firebase.installations.Installations,
74+
messaging: firebase.messaging(),
75+
performance: firebase.performance(),
76+
remoteConfig: firebase.remoteConfig(),
77+
storage: firebase.storage(),
78+
storageReference: {} as firebase.storage.Reference,
79+
firestoreDocumentReference: {} as firebase.firestore.DocumentReference,
80+
firestoreCollectionReference: {} as firebase.firestore.CollectionReference,
81+
authUser: {} as firebase.User,
82+
database: {} as firebase.database.Database,
83+
databaseReference: {} as firebase.database.Reference,
84+
databaseQuery: {} as firebase.database.Query
11085
};

packages/database-types/index.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export interface Query {
8888
callback: (a: DataSnapshot, b?: string | null) => any,
8989
cancelCallbackOrContext?: ((a: Error) => any) | Object | null,
9090
context?: Object | null
91-
): (a: DataSnapshot, b?: string | null) => any;
91+
): (a: DataSnapshot | null, b?: string | null) => any;
9292
once(
9393
eventType: EventType,
9494
successCallback?: (a: DataSnapshot, b?: string | null) => any,

0 commit comments

Comments
 (0)