Skip to content

Commit 2ac59f1

Browse files
Fix build
1 parent 0027ac1 commit 2ac59f1

File tree

2 files changed

+21
-18
lines changed

2 files changed

+21
-18
lines changed

packages/firestore/rollup.config.es2017.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ import {
3131
appendPrivatePrefixTransformers,
3232
manglePrivatePropertiesOptions,
3333
resolveNodeExterns,
34-
resolveBrowserExterns
34+
resolveBrowserExterns,
35+
browserDeps,
36+
nodeDeps
3537
} from './rollup.shared';
3638

3739
// This Firestore Rollup configuration provides a number of different builds:

packages/firestore/rollup.shared.js

+18-17
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,24 @@ import * as path from 'path';
2020
import { externs } from './externs.json';
2121
import { renameInternals } from './scripts/rename-internals';
2222
import { extractPublicIdentifiers } from './scripts/extract-api';
23-
import pkg from './package';
23+
24+
import pkg from './package.json';
25+
26+
export const browserDeps = Object.keys(
27+
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
28+
);
29+
30+
export const nodeDeps = [...browserDeps, 'util', 'path'];
31+
32+
/** Resolves the external dependencies for the browser build. */
33+
export function resolveBrowserExterns(id) {
34+
return browserDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
35+
}
36+
37+
/** Resolves the external dependencies for the Node build. */
38+
export function resolveNodeExterns(id) {
39+
return nodeDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
40+
}
2441

2542
const externsPaths = externs.map(p => path.resolve(__dirname, '../../', p));
2643
const publicIdentifiers = extractPublicIdentifiers(externsPaths);
@@ -54,19 +71,3 @@ export const manglePrivatePropertiesOptions = {
5471
}
5572
}
5673
};
57-
58-
const browserDeps = Object.keys(
59-
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
60-
);
61-
62-
const nodeDeps = [...browserDeps, 'util', 'path'];
63-
64-
/** Resolves the external dependencies for the browser build. */
65-
export function resolveBrowserExterns(id) {
66-
return browserDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
67-
}
68-
69-
/** Resolves the external dependencies for the Node build. */
70-
export function resolveNodeExterns(id) {
71-
return nodeDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
72-
}

0 commit comments

Comments
 (0)