Merge 2530280 into 772c4d1

Author: sam-gc

.changeset/wet-dolphins-play.md

@@ -0,0 +1,6 @@
+---
+"@firebase/auth": patch
+"firebase": patch
+---
+
+Fix issue with IndexedDB retry logic causing uncaught errors

packages/auth/src/storage/indexeddb.js

@@ -374,6 +374,12 @@ fireauth.storage.IndexedDB.prototype.withRetry_ = function(transaction) {
           db.close();
           this.initPromise_ = undefined;
           return attempt(resolve, reject);
+        }).thenCatch((error) => {
+          // Make sure any errors caused by initializeDbAndRun_() or
+          // db.close() are caught as well and trigger a rejection. If at
+          // this point, we are probably in a private browsing context or
+          // environment that does not support indexedDB.
+          reject(error);
         });
       });
   };

packages/auth/test/storage/indexeddb_test.js

@@ -413,6 +413,33 @@ function testIndexedDb_setGetRemove_connectionClosed() {
 }
 
 
+function testIndexedDb_failingOnDbOpen() {
+  manager = getDefaultFireauthManager();
+  manager.addStorageListener(() => {
+    fail('Storage should not be triggered for local changes!');
+  });
+  let errorThrown = false;
+  indexedDBMock.open = () => {
+    throw new Error('InvalidStateError: A mutation operation was attempted ' +
+                    'on a database that did not allow mutations.');
+  };
+  return goog.Promise.resolve()
+      .then(() => {
+        return manager.get('key1');
+      })
+      .thenCatch((error) => {
+        assertEquals(
+            error.message,
+            'InvalidStateError: A mutation operation was attempted on a ' +
+            'database that did not allow mutations.');
+        errorThrown = true;
+      })
+      .then(() => {
+        assertTrue(errorThrown);
+      });
+}
+
+
 function testStartListeners() {
   manager = getDefaultFireauthManager();
   var listener1 = goog.testing.recordFunction();