Fix Spec tests

Author: schmidt-sebastian

packages/firestore/test/unit/local/persistence_test_helpers.ts

@@ -59,11 +59,12 @@ export const MOCK_SEQUENCE_NUMBER_SYNCER: SequenceNumberSyncer = {
 
 /** The Database ID used by most tests that use a serializer. */
 export const TEST_DATABASE_ID = new DatabaseId('test-project');
+export const TEST_PERSISTENCE_KEY = '[PersistenceTestHelpers]';
 
 /** The DatabaseInfo used by tests that need a serializer. */
 const TEST_DATABASE_INFO = new DatabaseInfo(
   TEST_DATABASE_ID,
-  '[PersistenceTestHelpers]',
+  TEST_PERSISTENCE_KEY,
   'host',
   /*ssl=*/ false,
   /*forceLongPolling=*/ false

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -106,6 +106,8 @@ import { SharedFakeWebStorage, TestPlatform } from '../../util/test_platform';
 import {
   clearTestPersistence,
   INDEXEDDB_TEST_DATABASE_NAME,
+  TEST_DATABASE_ID,
+  TEST_PERSISTENCE_KEY,
   TEST_SERIALIZER
 } from '../local/persistence_test_helpers';
 import { MULTI_CLIENT_TAG } from './describe_spec';
@@ -439,8 +441,8 @@ abstract class TestRunner {
   ) {
     this.clientId = `client${clientIndex}`;
     this.databaseInfo = new DatabaseInfo(
-      new DatabaseId('project'),
-      'persistenceKey',
+      TEST_DATABASE_ID,
+      TEST_PERSISTENCE_KEY,
       'host',
       /*ssl=*/ false,
       /*forceLongPolling=*/ false
@@ -1295,8 +1297,6 @@ class IndexedDbTestRunner extends TestRunner {
     maxConcurrentLimboResolutions: number,
     gcEnabled: boolean
   ): Promise<ComponentProvider> {
-    assert(gcEnabled, 'IndexedDB persistence requires GC');
-
     const persistenceProvider = new IndexedDbComponentProvider();
     await persistenceProvider.initialize(
       asyncQueue,

packages/firestore/test/util/spec_test_helpers.ts

@@ -27,9 +27,9 @@ import { Document, NoDocument } from '../../src/model/document';
 import { mapRpcCodeFromCode } from '../../src/remote/rpc_error';
 import { fail } from '../../src/util/assert';
 import { JsonProtoSerializer } from '../../src/remote/serializer';
-import { dbId } from './helpers';
+import { TEST_DATABASE_ID } from "../unit/local/persistence_test_helpers";
 
-const serializer = new JsonProtoSerializer(dbId('project'), {
+const serializer = new JsonProtoSerializer(TEST_DATABASE_ID, {
   useProto3Json: true
 });