auth

Author: hsubox76

packages/auth-compat/demo/package.json

@@ -34,7 +34,7 @@
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/auth-compat/demo",

packages/auth-compat/package.json

@@ -61,7 +61,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/auth-compat",

packages/auth-interop-types/package.json

@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }

packages/auth-types/package.json

@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }

packages/auth/package.json

@@ -118,7 +118,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2",
+    "typescript": "4.7.4",
     "@types/express": "4.17.14"
   },
   "repository": {

packages/auth/src/api/index.test.ts

@@ -383,7 +383,7 @@ describe('api/_performApiRequest', () => {
         );
         assert.fail('Call should have failed');
       } catch (e) {
-        expect(e.code).to.eq(`auth/${AuthErrorCode.NEED_CONFIRMATION}`);
+        expect((e as FirebaseError).code).to.eq(`auth/${AuthErrorCode.NEED_CONFIRMATION}`);
         expect((e as FirebaseError).customData!._tokenResponse).to.eql({
           needConfirmation: true,
           idToken: 'id-token'
@@ -413,7 +413,7 @@ describe('api/_performApiRequest', () => {
         );
         assert.fail('Call should have failed');
       } catch (e) {
-        expect(e.code).to.eq(`auth/${AuthErrorCode.CREDENTIAL_ALREADY_IN_USE}`);
+        expect((e as FirebaseError).code).to.eq(`auth/${AuthErrorCode.CREDENTIAL_ALREADY_IN_USE}`);
         expect((e as FirebaseError).customData!._tokenResponse).to.eql(
           response
         );
@@ -444,7 +444,7 @@ describe('api/_performApiRequest', () => {
         );
         assert.fail('Call should have failed');
       } catch (e) {
-        expect(e.code).to.eq(`auth/${AuthErrorCode.EMAIL_EXISTS}`);
+        expect((e as FirebaseError).code).to.eq(`auth/${AuthErrorCode.EMAIL_EXISTS}`);
         expect((e as FirebaseError).customData!.email).to.eq('[email protected]');
         expect((e as FirebaseError).customData!.phoneNumber).to.eq(
           '+1555-this-is-a-number'

packages/auth/src/core/strategies/abstract_popup_redirect_operation.ts

@@ -76,7 +76,7 @@ export abstract class AbstractPopupRedirectOperation
           await this.onExecution();
           this.eventManager.registerConsumer(this);
         } catch (e) {
-          this.reject(e);
+          this.reject(e as Error);
         }
       }
     );
@@ -102,7 +102,7 @@ export abstract class AbstractPopupRedirectOperation
     try {
       this.resolve(await this.getIdpTask(type)(params));
     } catch (e) {
-      this.reject(e);
+      this.reject(e as Error);
     }
   }
 

packages/auth/src/platform_browser/popup_redirect.test.ts

@@ -93,7 +93,7 @@ describe('platform_browser/popup_redirect', () => {
   });
 
   context('#_openPopup', () => {
-    let popupUrl: string | undefined;
+    let popupUrl: string | URL | undefined;
     let provider: OAuthProvider;
     const event = AuthEventType.LINK_VIA_POPUP;
 

packages/auth/test/helpers/mock_fetch.ts

@@ -34,7 +34,7 @@ let fetchImpl: typeof fetch | null;
 const routes = new Map<string, Route>();
 
 // Using a constant rather than a function to enforce the type matches fetch()
-const fakeFetch: typeof fetch = (input: RequestInfo, request?: RequestInit) => {
+const fakeFetch: typeof fetch = (input: RequestInfo | URL, request?: RequestInit) => {
   if (typeof input !== 'string') {
     throw new Error('URL passed to fetch was not a string');
   }

repo-scripts/size-analysis/analysis-helper.ts

@@ -263,7 +263,7 @@ export function extractExports(filePath: string): MemberList {
   for (const expt of exports) {
     // get the source declaration where we can determine the type of the export. e.g. class vs function
     let sourceSymbol = expt;
-    if (sourceSymbol.declarations[0].kind === ts.SyntaxKind.ExportSpecifier) {
+    if (sourceSymbol.declarations?.[0].kind === ts.SyntaxKind.ExportSpecifier) {
       sourceSymbol = checker.getAliasedSymbol(expt);
     }