Skip to content

Commit 22a41b6

Browse files
Better isEqual
1 parent 7b67401 commit 22a41b6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/firestore/src/api/field_value.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class ArrayUnionFieldValueImpl extends FieldValueImpl {
115115

116116
isEqual(other: FieldValue): boolean {
117117
// TODO(mrschmidt): Implement isEquals
118-
return false;
118+
return this === other;
119119
}
120120
}
121121

@@ -141,7 +141,7 @@ export class ArrayRemoveFieldValueImpl extends FieldValueImpl {
141141

142142
isEqual(other: FieldValue): boolean {
143143
// TODO(mrschmidt): Implement isEquals
144-
return false;
144+
return this === other;
145145
}
146146
}
147147

@@ -162,7 +162,7 @@ export class NumericIncrementFieldValueImpl extends FieldValueImpl {
162162

163163
isEqual(other: FieldValue): boolean {
164164
// TODO(mrschmidt): Implement isEquals
165-
return false;
165+
return this === other;
166166
}
167167
}
168168

0 commit comments

Comments
 (0)