Skip to content

Commit 1f4e73d

Browse files
committed
Respond to review comments
1 parent 4473d2b commit 1f4e73d

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.github/workflows/test-all.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,6 @@ jobs:
9191
run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
9292
- name: Run unit tests
9393
# Ignore auth and firestore since they're handled in their own separate jobs.
94-
# TODO (dlarocque): Fix flakes in installations, database, database-compat, storage-compat,
95-
# and remote-config, and then run them here.
96-
# There are several tests suites that are flaky when ran alongside the other tests in
97-
# WebkitHeadless. It's unclear why they're only failing when ran with other tests, so let's
98-
# skip them for now.
9994
run: |
10095
xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/firestore*,firebase-firestore-integration-test}' test:ci
10196
node scripts/print_test_logs.js

.github/workflows/test-changed-firestore.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ name: Test Firestore
1616

1717
on:
1818
workflow_dispatch:
19-
push:
19+
pull_request:
2020

2121
env:
2222
artifactRetentionDays: 14

0 commit comments

Comments
 (0)