Skip to content

Commit 1b15844

Browse files
authored
Fix typing issues in storage exp (#4334)
1 parent 872c543 commit 1b15844

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

packages/storage-types/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
"scripts": {
88
"test": "tsc",
99
"test:ci": "node ../../scripts/run_tests_in_ci.js",
10-
"api-report": "api-extractor run --local --verbose"
10+
"api-report": "api-extractor run --local --verbose",
11+
"build:exp:release": "node ../../scripts/exp/remove-exp.js ./exp/index.d.ts"
1112
},
1213
"files": [
1314
"index.d.ts"

packages/storage/exp/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ import {
1919
_registerComponent,
2020
registerVersion,
2121
_getProvider,
22-
SDK_VERSION,
23-
FirebaseApp
22+
SDK_VERSION
2423
// eslint-disable-next-line import/no-extraneous-dependencies
2524
} from '@firebase/app-exp';
25+
import { FirebaseApp } from '@firebase/app-types-exp';
2626

2727
import { XhrIoPool } from '../src/implementation/xhriopool';
2828
import {

scripts/exp/release.ts

+10
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,16 @@ async function buildPackages() {
265265
}
266266
);
267267

268+
// storage-types. Remove -exp in import paths in d.ts
269+
await spawn(
270+
'yarn',
271+
['lerna', 'run', '--scope', '@firebase/storage-types', 'build:exp:release'],
272+
{
273+
cwd: projectRoot,
274+
stdio: 'inherit'
275+
}
276+
);
277+
268278
// Database
269279
await spawn(
270280
'yarn',

0 commit comments

Comments
 (0)