Make spec test only

Author: schmidt-sebastian

packages/firestore/src/local/indexeddb_persistence.ts

@@ -63,7 +63,6 @@ import {
 } from './lru_garbage_collector';
 import {
   Persistence,
-  PersistenceAction,
   PersistenceTransaction,
   PersistenceTransactionMode,
   PRIMARY_LEASE_LOST_ERROR_MSG,
@@ -750,7 +749,7 @@ export class IndexedDbPersistence implements Persistence {
   }
 
   runTransaction<T>(
-    action: PersistenceAction,
+    action: string,
     mode: PersistenceTransactionMode,
     transactionOperation: (
       transaction: PersistenceTransaction

packages/firestore/src/local/persistence.ts

@@ -31,35 +31,6 @@ export const PRIMARY_LEASE_LOST_ERROR_MSG =
   'The current tab is not in the required state to perform this operation. ' +
   'It might be necessary to refresh the browser tab.';
 
-/**
- * The cumulative list of actions run against Persistence. This is used by the
- * Spec tests to fail specific types of actions.
- */
-export type PersistenceAction =
-  | 'Get next mutation batch'
-  | 'read document'
-  | 'Allocate target'
-  | 'Release target'
-  | 'Execute query'
-  | 'Handle user change'
-  | 'Locally write mutations'
-  | 'Acknowledge batch'
-  | 'Reject batch'
-  | 'Get highest unacknowledged batch id'
-  | 'Get last stream token'
-  | 'Set last stream token'
-  | 'Get last remote snapshot version'
-  | 'Set last remote snapshot version'
-  | 'Apply remote event'
-  | 'notifyLocalViewChanges'
-  | 'Remote document keys'
-  | 'Collect garbage'
-  | 'maybeGarbageCollectMultiClientState'
-  | 'Lookup mutation documents'
-  | 'Get target data'
-  | 'Get new document changes'
-  | 'Synchronize last document change read time';
-
 /**
  * A base class representing a persistence transaction, encapsulating both the
  * transaction's sequence numbers as well as a list of onCommitted listeners.
@@ -278,7 +249,7 @@ export interface Persistence {
    * @return A promise that is resolved once the transaction completes.
    */
   runTransaction<T>(
-    action: PersistenceAction,
+    action: string,
     mode: PersistenceTransactionMode,
     transactionOperation: (
       transaction: PersistenceTransaction

packages/firestore/test/unit/specs/spec_test_components.ts

@@ -23,7 +23,6 @@ import {
 import {
   GarbageCollectionScheduler,
   Persistence,
-  PersistenceAction,
   PersistenceTransaction,
   PersistenceTransactionMode
 } from '../../../src/local/persistence';
@@ -37,7 +36,7 @@ import {
   MemoryPersistence
 } from '../../../src/local/memory_persistence';
 import { LruParams } from '../../../src/local/lru_garbage_collector';
-import { SpecDatabaseFailures } from './spec_test_runner';
+import { PersistenceAction, SpecDatabaseFailures } from './spec_test_runner';
 import { Connection, Stream } from '../../../src/remote/connection';
 import { StreamBridge } from '../../../src/remote/stream_bridge';
 import * as api from '../../../src/protos/firestore_proto_api';
@@ -61,17 +60,17 @@ export class MockMemoryPersistence extends MemoryPersistence {
   injectFailures?: SpecDatabaseFailures;
 
   runTransaction<T>(
-    action: PersistenceAction,
+    action: string,
     mode: PersistenceTransactionMode,
     transactionOperation: (
       transaction: PersistenceTransaction
     ) => PersistencePromise<T>
   ): Promise<T> {
     if (this.injectFailures) {
-      if (this.injectFailures[action] === undefined) {
+      if (this.injectFailures[action as PersistenceAction] === undefined) {
         throw fail('Failure mode not specified for action: ' + action);
       }
-      if (this.injectFailures[action]) {
+      if (this.injectFailures[action as PersistenceAction]) {
         return Promise.reject(
           new IndexedDbTransactionError(new Error('Simulated retryable error'))
         );
@@ -90,16 +89,16 @@ export class MockIndexedDbPersistence extends IndexedDbPersistence {
   injectFailures?: SpecDatabaseFailures;
 
   runTransaction<T>(
-    action: PersistenceAction,
+    action: string,
     mode: PersistenceTransactionMode,
     transactionOperation: (
       transaction: PersistenceTransaction
     ) => PersistencePromise<T>
   ): Promise<T> {
     if (this.injectFailures) {
-      if (this.injectFailures[action] === undefined) {
+      if (this.injectFailures[action as PersistenceAction] === undefined) {
         throw fail('Failure mode not specified for action: ' + action);
-      } else if (this.injectFailures[action]) {
+      } else if (this.injectFailures[action as PersistenceAction]) {
         return Promise.reject(
           new IndexedDbTransactionError(new Error('Simulated retryable error'))
         );

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -113,7 +113,6 @@ import {
   SharedWriteTracker
 } from './spec_test_components';
 import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
-import { PersistenceAction } from '../../../src/local/persistence';
 
 const ARBITRARY_SEQUENCE_NUMBER = 2;
 
@@ -1184,6 +1183,35 @@ export interface SpecConfig {
   maxConcurrentLimboResolutions?: number;
 }
 
+/**
+ * The cumulative list of actions run against Persistence. This is used by the
+ * Spec tests to fail specific types of actions.
+ */
+export type PersistenceAction =
+  | 'Get next mutation batch'
+  | 'read document'
+  | 'Allocate target'
+  | 'Release target'
+  | 'Execute query'
+  | 'Handle user change'
+  | 'Locally write mutations'
+  | 'Acknowledge batch'
+  | 'Reject batch'
+  | 'Get highest unacknowledged batch id'
+  | 'Get last stream token'
+  | 'Set last stream token'
+  | 'Get last remote snapshot version'
+  | 'Set last remote snapshot version'
+  | 'Apply remote event'
+  | 'notifyLocalViewChanges'
+  | 'Remote document keys'
+  | 'Collect garbage'
+  | 'maybeGarbageCollectMultiClientState'
+  | 'Lookup mutation documents'
+  | 'Get target data'
+  | 'Get new document changes'
+  | 'Synchronize last document change read time';
+
 /** Specifies failure or success for a list of database actions. */
 export type SpecDatabaseFailures = Partial<
   {