Skip to content

Commit 16984af

Browse files
committed
check-changeset.yml: replace 'echo' with 'cat << [heredoc]' to avoid interpolation of special characters in CHANGESET_ERROR_MESSAGE
This fixes the following error in the "Print changeset checker output" step: ``` /home/runner/work/_temp/05ad4244-c741-4473-b5fa-88197e013f3c.sh: line 1: fg: no job control /home/runner/work/_temp/05ad4244-c741-4473-b5fa-88197e013f3c.sh: command substitution: line 1: unexpected EOF while looking for matching `'' /home/runner/work/_temp/05ad4244-c741-4473-b5fa-88197e013f3c.sh: command substitution: line 2: syntax error: unexpected end of file /home/runner/work/_temp/05ad4244-c741-4473-b5fa-88197e013f3c.sh: line 1: .%0A: command not found - Changeset formatting error in following file:%0A changeset addchangeset add --empty%0A ``` e.g. https://github.com/firebase/firebase-js-sdk/actions/runs/7586786834/job/20665754718
1 parent c12d6e5 commit 16984af

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/check-changeset.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ jobs:
4747
yarn ts-node-script scripts/ci/check_changeset.ts
4848
id: check-changeset
4949
- name: Print changeset checker output
50-
run: echo "${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}"
50+
run: |
51+
cat << 'eof_delimiter_that_will_never_occur_in_CHANGESET_ERROR_MESSAGE'
52+
${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
53+
eof_delimiter_that_will_never_occur_in_CHANGESET_ERROR_MESSAGE
5154
- name: Print blocking failure status
5255
run: echo "${{steps.check-changeset.outputs.BLOCKING_FAILURE}}"
5356
- name: Find Comment

0 commit comments

Comments
 (0)