Skip to content

Commit 159df22

Browse files
committed
watch_change.ts: don't return bloomFilterMightContain if bitCount===0
1 parent d36e50a commit 159df22

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

packages/firestore/src/remote/watch_change.ts

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -523,28 +523,19 @@ export class WatchChangeAggregator {
523523
};
524524

525525
if (bloomFilter.bitCount === 0) {
526-
return {
527-
status: BloomFilterApplicationStatus.Skipped,
528-
bloomFilterMightContain
529-
};
526+
return { status: BloomFilterApplicationStatus.Skipped };
530527
}
531528

532529
const removedDocumentCount = this.filterRemovedDocuments(
533530
watchChange.targetId,
534531
bloomFilterMightContain
535532
);
536533

537-
if (expectedCount !== currentCount - removedDocumentCount) {
538-
return {
539-
status: BloomFilterApplicationStatus.FalsePositive,
540-
bloomFilterMightContain
541-
};
542-
}
543-
544-
return {
545-
status: BloomFilterApplicationStatus.Success,
546-
bloomFilterMightContain
547-
};
534+
const status =
535+
expectedCount === currentCount - removedDocumentCount
536+
? BloomFilterApplicationStatus.Success
537+
: BloomFilterApplicationStatus.FalsePositive;
538+
return { status, bloomFilterMightContain };
548539
}
549540

550541
/**

0 commit comments

Comments
 (0)