Skip to content

Commit 13abf2d

Browse files
authored
FDC: Upgrade to v1beta (#8485)
1 parent ac13c80 commit 13abf2d

File tree

7 files changed

+11
-25
lines changed

7 files changed

+11
-25
lines changed

packages/data-connect/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"dev": "rollup -c -w",
3636
"test": "run-p --npm-path npm test:emulator",
3737
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:emulator",
38-
"test:all": "npm run test:unit",
38+
"test:all": "run-p --npm-path npm lint test:unit",
3939
"test:browser": "karma start --single-run",
4040
"test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
4141
"test:unit": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/unit/**/*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",

packages/data-connect/src/util/url.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function urlBuilder(
3737
'Incorrect type for port passed in!'
3838
);
3939
}
40-
return `${baseUrl}/v1alpha/projects/${project}/locations/${location}/services/${service}/connectors/${connector}`;
40+
return `${baseUrl}/v1beta/projects/${project}/locations/${location}/services/${service}/connectors/${connector}`;
4141
}
4242
export function addToken(url: string, apiKey?: string): string {
4343
if (!apiKey) {

packages/data-connect/test/dataconnect/connector/connector.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ authMode: "PUBLIC"
33
generate:
44
javascriptSdk:
55
outputDir: "./gen/web"
6-
jsPackageName: "@movie-app-ssr/movies"
6+
package: "@movie-app-ssr/movies"

packages/data-connect/test/dataconnect/dataconnect.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
specVersion: "v1alpha"
1+
specVersion: "v1beta"
22
serviceId: "dataconnect"
3+
location: "us-west2"
34
schema:
45
source: "./schema"
56
datasource:

packages/data-connect/test/unit/userAgent.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('User Agent Tests', () => {
5454
// @ts-ignore
5555
await executeQuery(queryRef(dc, '')).catch(() => {});
5656
expect(fakeFetchImpl).to.be.calledWithMatch(
57-
'https://firebasedataconnect.googleapis.com/v1alpha/projects/p/locations/l/services/s/connectors/c:executeQuery',
57+
'https://firebasedataconnect.googleapis.com/v1beta/projects/p/locations/l/services/s/connectors/c:executeQuery',
5858
{
5959
headers: {
6060
['X-Goog-Api-Client']: 'gl-js/ fire/' + SDK_VERSION + ' web/gen'
@@ -66,7 +66,7 @@ describe('User Agent Tests', () => {
6666
// @ts-ignore
6767
await executeQuery(queryRef(dc, '')).catch(() => {});
6868
expect(fakeFetchImpl).to.be.calledWithMatch(
69-
'https://firebasedataconnect.googleapis.com/v1alpha/projects/p/locations/l/services/s/connectors/c:executeQuery',
69+
'https://firebasedataconnect.googleapis.com/v1beta/projects/p/locations/l/services/s/connectors/c:executeQuery',
7070
{
7171
headers: {
7272
['X-Goog-Api-Client']: 'gl-js/ fire/' + SDK_VERSION

scripts/emulator-testing/emulators/dataconnect-emulator.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import { platform } from 'os';
1919
import { Emulator } from './emulator';
2020

21-
const DATABASE_EMULATOR_VERSION = '1.1.17';
21+
const DATABASE_EMULATOR_VERSION = '1.3.7';
2222

2323
export class DataConnectEmulator extends Emulator {
2424
// namespace: string;
@@ -29,15 +29,15 @@ export class DataConnectEmulator extends Emulator {
2929
switch (os) {
3030
case 'darwin':
3131
urlString =
32-
'https://firebasestorage.googleapis.com/v0/b/firemat-preview-drop/o/emulator%2Fdataconnect-emulator-macos-v1.3.5?alt=media&token=52c3db6e-2a2a-4094-a482-a8c85ae67a88';
32+
'https://firebasestorage.googleapis.com/v0/b/firemat-preview-drop/o/emulator%2Fdataconnect-emulator-macos-v1.3.7?alt=media&token=2cf32435-d479-4929-b963-a97ae1ac3f0b';
3333
break;
3434
case 'linux':
3535
urlString =
36-
'https://firebasestorage.googleapis.com/v0/b/firemat-preview-drop/o/emulator%2Fdataconnect-emulator-linux-v1.3.5?alt=media&token=bafb1f81-2a27-4851-b655-59934985b492';
36+
'https://firebasestorage.googleapis.com/v0/b/firemat-preview-drop/o/emulator%2Fdataconnect-emulator-linux-v1.3.7?alt=media&token=fd33b4fc-2e27-4874-893a-2d1f0ecbf116';
3737
break;
3838
case 'win32':
3939
urlString =
40-
'https://firebasestorage.googleapis.com/v0/b/firemat-preview-drop/o/emulator%2Fdataconnect-emulator-windows-v1.3.5?alt=media&token=d3d04c57-992f-4a4b-931d-5c90efd54c5a';
40+
'https://firebasestorage.googleapis.com/v0/b/firemat-preview-drop/o/emulator%2Fdataconnect-emulator-windows-v1.3.7?alt=media&token=bd6e60b0-50b4-46db-aa6c-5fcc6e991f39';
4141
break;
4242
default:
4343
throw new Error(

yarn.lock

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,21 +1639,6 @@
16391639
resolved "https://registry.npmjs.org/@eslint/js/-/js-8.56.0.tgz#ef20350fec605a7f7035a01764731b2de0f3782b"
16401640
integrity sha512-gMsVel9D7f2HLkBma9VbtzZRehRogVRfbr++f06nL2vnCGCNlzOD+/MUov/F4p8myyAHspEhVobgjpX64q5m6A==
16411641

1642-
"@firebase/[email protected]":
1643-
version "0.6.8"
1644-
resolved "https://registry.npmjs.org/@firebase/component/-/component-0.6.8.tgz#899b9318c0ce0586580e8cda7eaf61296f7fb43b"
1645-
integrity sha512-LcNvxGLLGjBwB0dJUsBGCej2fqAepWyBubs4jt1Tiuns7QLbXHuyObZ4aMeBjZjWx4m8g1LoVI9QFpSaq/k4/g==
1646-
dependencies:
1647-
"@firebase/util" "1.9.7"
1648-
tslib "^2.1.0"
1649-
1650-
"@firebase/[email protected]":
1651-
version "1.9.7"
1652-
resolved "https://registry.npmjs.org/@firebase/util/-/util-1.9.7.tgz#c03b0ae065b3bba22800da0bd5314ef030848038"
1653-
integrity sha512-fBVNH/8bRbYjqlbIhZ+lBtdAAS4WqZumx03K06/u7fJSpz1TGjEMm1ImvKD47w+xaFKIP2ori6z8BrbakRfjJA==
1654-
dependencies:
1655-
tslib "^2.1.0"
1656-
16571642
"@gar/promisify@^1.0.1":
16581643
version "1.1.2"
16591644
resolved "https://registry.npmjs.org/@gar/promisify/-/promisify-1.1.2.tgz"

0 commit comments

Comments
 (0)