Skip to content

Commit 11718f5

Browse files
committed
add test case for override issue
1 parent 6a4a324 commit 11718f5

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

packages/vertexai/src/models/generative-model.test.ts

+11-3
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,10 @@ describe('GenerativeModel', () => {
256256
{ functionDeclarations: [{ name: 'myfunc', description: 'mydesc' }] }
257257
],
258258
toolConfig: { functionCallingConfig: { mode: FunctionCallingMode.NONE } },
259-
systemInstruction: { role: 'system', parts: [{ text: 'be friendly' }] }
259+
systemInstruction: { role: 'system', parts: [{ text: 'be friendly' }] },
260+
generationConfig: {
261+
responseMimeType: 'image/jpeg'
262+
}
260263
});
261264
expect(genModel.tools?.length).to.equal(1);
262265
expect(genModel.toolConfig?.functionCallingConfig?.mode).to.equal(
@@ -282,7 +285,10 @@ describe('GenerativeModel', () => {
282285
toolConfig: {
283286
functionCallingConfig: { mode: FunctionCallingMode.AUTO }
284287
},
285-
systemInstruction: { role: 'system', parts: [{ text: 'be formal' }] }
288+
systemInstruction: { role: 'system', parts: [{ text: 'be formal' }] },
289+
generationConfig: {
290+
responseMimeType: 'image/png'
291+
}
286292
})
287293
.sendMessage('hello');
288294
expect(makeRequestStub).to.be.calledWith(
@@ -294,7 +300,9 @@ describe('GenerativeModel', () => {
294300
return (
295301
value.includes('otherfunc') &&
296302
value.includes(FunctionCallingMode.AUTO) &&
297-
value.includes('be formal')
303+
value.includes('be formal') &&
304+
value.includes('image/png') &&
305+
!value.includes('image/jpeg')
298306
);
299307
}),
300308
{}

0 commit comments

Comments
 (0)