Fixed build?

Author: DellaBitta

packages/functions/src/config.ts

@@ -36,7 +36,6 @@ const MESSAGING_INTERNAL_NAME: MessagingInternalComponentName =
   'messaging-internal';
 
 export function registerFunctions(
-  fetchImpl: typeof fetch,
   variant?: string
 ): void {
   const factory: InstanceFactory<'functions'> = (
@@ -55,8 +54,7 @@ export function registerFunctions(
       authProvider,
       messagingProvider,
       appCheckProvider,
-      regionOrCustomDomain,
-      fetchImpl
+      regionOrCustomDomain
     );
   };
 

packages/functions/src/index.node.ts

@@ -19,4 +19,4 @@ import { registerFunctions } from './config';
 export * from './api';
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-registerFunctions(fetch, 'node');
+registerFunctions('node');

packages/functions/src/index.ts

@@ -25,4 +25,4 @@ import { registerFunctions } from './config';
 export * from './api';
 export * from './public-types';
 
-registerFunctions(fetch.bind(self));
+registerFunctions();

packages/functions/src/service.ts

@@ -104,8 +104,7 @@ export class FunctionsService implements _FirebaseService {
     authProvider: Provider<FirebaseAuthInternalName>,
     messagingProvider: Provider<MessagingInternalComponentName>,
     appCheckProvider: Provider<AppCheckInternalComponentName>,
-    regionOrCustomDomain: string = DEFAULT_REGION,
-    readonly fetchImpl: typeof fetch
+    regionOrCustomDomain: string = DEFAULT_REGION
   ) {
     this.contextProvider = new ContextProvider(
       authProvider,
@@ -212,14 +211,13 @@ export function httpsCallableFromURL<RequestData, ResponseData>(
 async function postJSON(
   url: string,
   body: unknown,
-  headers: { [key: string]: string },
-  fetchImpl: typeof fetch
+  headers: { [key: string]: string }
 ): Promise<HttpResponse> {
   headers['Content-Type'] = 'application/json';
 
   let response: Response;
   try {
-    response = await fetchImpl(url, {
+    response = await fetch(url, {
       method: 'POST',
       body: JSON.stringify(body),
       headers
@@ -296,7 +294,7 @@ async function callAtURL(
 
   const failAfterHandle = failAfter(timeout);
   const response = await Promise.race([
-    postJSON(url, body, headers, functionsInstance.fetchImpl),
+    postJSON(url, body, headers),
     failAfterHandle.promise,
     functionsInstance.cancelAllRequests
   ]);

packages/functions/test/utils.ts

@@ -62,8 +62,7 @@ export function createTestService(
     authProvider,
     messagingProvider,
     appCheckProvider,
-    region,
-    fetch
+    region
   );
   const useEmulator = !!process.env.FIREBASE_FUNCTIONS_EMULATOR_ORIGIN;
   if (useEmulator) {