Remove references to app-types from packages-exp

Author: hsubox76

common/api-review/auth-exp.api.md

@@ -216,8 +216,10 @@ export class EmailAuthProvider implements AuthProvider {
     readonly providerId = ProviderId.PASSWORD;
 }
 
+// Warning: (ae-forgotten-export) The symbol "BaseOAuthProvider" needs to be exported by the entry point index.d.ts
+//
 // @public
-export class FacebookAuthProvider extends OAuthProvider {
+export class FacebookAuthProvider extends BaseOAuthProvider {
     constructor();
     static credential(accessToken: string): OAuthCredential;
     static credentialFromError(error: FirebaseError): OAuthCredential | null;
@@ -255,7 +257,7 @@ export function getMultiFactorResolver(auth: Auth, error: MultiFactorError_2): M
 export function getRedirectResult(auth: Auth, resolver?: PopupRedirectResolver): Promise<UserCredential | null>;
 
 // @public
-export class GithubAuthProvider extends OAuthProvider {
+export class GithubAuthProvider extends BaseOAuthProvider {
     constructor();
     static credential(accessToken: string): OAuthCredential;
     static credentialFromError(error: FirebaseError): OAuthCredential | null;
@@ -265,7 +267,7 @@ export class GithubAuthProvider extends OAuthProvider {
 }
 
 // @public
-export class GoogleAuthProvider extends OAuthProvider {
+export class GoogleAuthProvider extends BaseOAuthProvider {
     constructor();
     static credential(idToken?: string | null, accessToken?: string | null): OAuthCredential;
     static credentialFromError(error: FirebaseError): OAuthCredential | null;
@@ -380,23 +382,13 @@ export interface OAuthCredentialOptions {
 }
 
 // @public
-export class OAuthProvider implements AuthProvider {
-    constructor(providerId: string);
-    addScope(scope: string): AuthProvider;
+export class OAuthProvider extends BaseOAuthProvider {
     credential(params: OAuthCredentialOptions): OAuthCredential;
     static credentialFromError(error: FirebaseError): OAuthCredential | null;
     // (undocumented)
     static credentialFromJSON(json: object | string): OAuthCredential;
     static credentialFromResult(userCredential: UserCredential): OAuthCredential | null;
-    // @internal (undocumented)
-    defaultLanguageCode: string | null;
-    getCustomParameters(): CustomParameters;
-    getScopes(): string[];
-    // (undocumented)
-    readonly providerId: string;
-    setCustomParameters(customOAuthParameters: CustomParameters): AuthProvider;
-    setDefaultLanguage(languageCode: string | null): void;
-}
+    }
 
 // @public
 export function onAuthStateChanged(auth: Auth, nextOrObserver: NextOrObserver<User>, error?: ErrorFn, completed?: CompleteFn): Unsubscribe;
@@ -566,6 +558,19 @@ export class RecaptchaVerifier implements ApplicationVerifierInternal {
 // @public
 export function reload(user: User): Promise<void>;
 
+// Warning: (ae-forgotten-export) The symbol "FederatedAuthProvider" needs to be exported by the entry point index.d.ts
+//
+// @public
+export class SAMLAuthProvider extends FederatedAuthProvider {
+    constructor(providerId: string);
+    // (undocumented)
+    static credentialFromError(error: FirebaseError): AuthCredential | null;
+    // (undocumented)
+    static credentialFromJSON(json: string | object): AuthCredential;
+    // (undocumented)
+    static credentialFromResult(userCredential: UserCredential): AuthCredential | null;
+    }
+
 // @public
 export function sendEmailVerification(user: User, actionCodeSettings?: ActionCodeSettings | null): Promise<void>;
 
@@ -626,7 +631,7 @@ export function signInWithRedirect(auth: Auth, provider: AuthProvider, resolver?
 export function signOut(auth: Auth): Promise<void>;
 
 // @public
-export class TwitterAuthProvider extends OAuthProvider {
+export class TwitterAuthProvider extends BaseOAuthProvider {
     constructor();
     static credential(token: string, secret: string): OAuthCredential;
     static credentialFromError(error: FirebaseError): OAuthCredential | null;

packages-exp/analytics-compat/src/service.test.ts

@@ -16,8 +16,7 @@
  */
 import { expect, use } from 'chai';
 import { AnalyticsService } from './service';
-import { firebase } from '@firebase/app-compat';
-import { FirebaseApp } from '@firebase/app-types';
+import { firebase, FirebaseApp } from '@firebase/app-compat';
 import * as analyticsExp from '@firebase/analytics-exp';
 import { stub, match, SinonStub } from 'sinon';
 import * as sinonChai from 'sinon-chai';

packages-exp/performance-compat/package.json

@@ -27,8 +27,7 @@
   },
   "license": "Apache-2.0",
   "peerDependencies": {
-    "@firebase/app-compat": "0.x",
-    "@firebase/app-types": "0.x"
+    "@firebase/app-compat": "0.x"
   },
   "dependencies": {
     "@firebase/performance-exp": "0.0.900",

packages-exp/performance-compat/src/performance.ts

@@ -15,15 +15,14 @@
  * limitations under the License.
  */
 
-import { FirebaseApp } from '@firebase/app-types';
 import {
   trace,
   FirebasePerformance,
   // The PerformanceTrace type has not changed between modular and non-modular packages.
   PerformanceTrace
 } from '@firebase/performance-exp';
 import { FirebasePerformance as FirebasePerformanceCompat } from '@firebase/performance-types';
-import { _FirebaseService } from '@firebase/app-compat';
+import { FirebaseApp, _FirebaseService } from '@firebase/app-compat';
 
 export class PerformanceCompatImpl
   implements FirebasePerformanceCompat, _FirebaseService {

packages-exp/performance-compat/test/util.ts

@@ -15,7 +15,8 @@
  * limitations under the License.
  */
 
-import { FirebaseApp } from '@firebase/app-types';
+import { FirebaseApp } from '@firebase/app-compat';
+import { _FirebaseAppInternal } from '@firebase/app-exp';
 import {
   FirebasePerformance,
   PerformanceTrace
@@ -34,7 +35,8 @@ export function getFakeApp(): FirebaseApp {
       appId: '1:777777777777:web:d93b5ca1475efe57'
     },
     automaticDataCollectionEnabled: true,
-    delete: async () => {}
+    delete: async () => {},
+    _delegate: {} as _FirebaseAppInternal
   };
 }