Enable noUnusedLocals in TS compiler options (#672)

* Enable noUnusedLocals in TS compiler options

* [AUTOMATED]: Prettier Code Styling

Author: mmermerkaya

packages/messaging/src/controllers/controller-interface.ts

@@ -15,13 +15,7 @@
  */
 
 import { FirebaseApp } from '@firebase/app-types';
-import {
-  createSubscribe,
-  ErrorFactory,
-  NextFn,
-  Observer,
-  PartialObserver
-} from '@firebase/util';
+import { ErrorFactory, NextFn, PartialObserver } from '@firebase/util';
 import { isArrayBufferEqual } from '../helpers/is-array-buffer-equal';
 import { TokenDetails } from '../interfaces/token-details';
 import { ERROR_CODES, ERROR_MAP } from '../models/errors';

packages/messaging/src/controllers/sw-controller.ts

@@ -15,6 +15,7 @@
  */
 
 import { FirebaseApp } from '@firebase/app-types';
+
 import { ERROR_CODES } from '../models/errors';
 import { DEFAULT_PUBLIC_VAPID_KEY } from '../models/fcm-details';
 import * as WorkerPageMessage from '../models/worker-page-message';
@@ -123,7 +124,7 @@ export class SWController extends ControllerInterface {
     }
 
     try {
-      const subscription = await registration.pushManager.getSubscription();
+      await registration.pushManager.getSubscription();
       // TODO: Check if it's still valid. If not, then update token.
     } catch (err) {
       // The best thing we can do is log this to the terminal so
@@ -185,7 +186,6 @@ export class SWController extends ControllerInterface {
     }
 
     // Delete notification data from payload before sending to the page.
-    const notificationData = msgPayload['notification'];
     delete msgPayload['notification'];
 
     const internalMsg = WorkerPageMessage.createNewMsg(

packages/messaging/src/controllers/window-controller.ts

@@ -24,15 +24,14 @@ import {
   Subscribe,
   Unsubscribe
 } from '@firebase/util';
+
 import { base64ToArrayBuffer } from '../helpers/base64-to-array-buffer';
 import { DEFAULT_SW_PATH, DEFAULT_SW_SCOPE } from '../models/default-sw';
 import { ERROR_CODES } from '../models/errors';
 import { DEFAULT_PUBLIC_VAPID_KEY } from '../models/fcm-details';
 import * as WorkerPageMessage from '../models/worker-page-message';
 import { ControllerInterface } from './controller-interface';
 
-declare const firebase: any;
-
 export class WindowController extends ControllerInterface
   implements FirebaseMessaging {
   private registrationToUse_: ServiceWorkerRegistration | null = null;
@@ -42,6 +41,7 @@ export class WindowController extends ControllerInterface
   private readonly onMessage_: Subscribe<{}> = createSubscribe(observer => {
     this.messageObserver_ = observer;
   });
+  // @ts-ignore: Unused variable error, this is not implemented yet.
   private tokenRefreshObserver_: Observer<{}, Error> | null = null;
   private readonly onTokenRefresh_: Subscribe<{}> = createSubscribe(
     observer => {

packages/messaging/src/models/db-interface.ts

@@ -16,7 +16,7 @@
 
 import { ErrorFactory } from '@firebase/util';
 
-import { ERROR_CODES, ERROR_MAP } from './errors';
+import { ERROR_MAP } from './errors';
 
 export abstract class DBInterface {
   private dbPromise: Promise<IDBDatabase> | null = null;

packages/messaging/src/models/iid-model.ts

@@ -14,10 +14,9 @@
  * limitations under the License.
  */
 
-import { base64, ErrorFactory } from '@firebase/util';
+import { ErrorFactory } from '@firebase/util';
 
 import { arrayBufferToBase64 } from '../helpers/array-buffer-to-base64';
-import { TokenDetails } from '../interfaces/token-details';
 import { ERROR_CODES, ERROR_MAP } from './errors';
 import { DEFAULT_PUBLIC_VAPID_KEY, ENDPOINT } from './fcm-details';
 

packages/messaging/src/models/token-details-model.ts

@@ -245,15 +245,3 @@ export class TokenDetailsModel extends DBInterface {
     return details;
   }
 }
-
-/** Promisifies an IDBRequest. Resolves with the IDBRequest's result. */
-function promisify<ReturnType>(request: IDBRequest): Promise<ReturnType> {
-  return new Promise<ReturnType>((resolve, reject) => {
-    request.onsuccess = () => {
-      resolve(request.result);
-    };
-    request.onerror = () => {
-      reject(request.error);
-    };
-  });
-}

packages/messaging/test/controller-get-token.test.ts

@@ -15,10 +15,8 @@
  */
 import { assert, expect } from 'chai';
 import * as sinon from 'sinon';
-import {
-  ControllerInterface,
-  TOKEN_EXPIRATION_MILLIS
-} from '../src/controllers/controller-interface';
+
+import { ControllerInterface } from '../src/controllers/controller-interface';
 import { SWController } from '../src/controllers/sw-controller';
 import { WindowController } from '../src/controllers/window-controller';
 import { base64ToArrayBuffer } from '../src/helpers/base64-to-array-buffer';

packages/messaging/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "strict": true
+    "strict": true,
+    "noUnusedLocals": true
   },
   "exclude": [
     "dist/**/*"