address comments

Author: Feiyang1

.changeset/config.json

@@ -14,7 +14,6 @@
     "firebase-firestore-integration-test",
     "firebase-messaging-integration-test",
     "@firebase/app-exp",
-    "@firebase/app-types-exp",
     "@firebase/analytics-exp",
     "@firebase/analytics-types-exp",
     "@firebase/auth-exp",

common/api-review/app-exp.api.md

@@ -40,15 +40,13 @@ export interface FirebaseApp {
     readonly options: FirebaseOptions;
 }
 
-// @public (undocumented)
+// @public
 export interface FirebaseAppConfig {
-    // (undocumented)
     automaticDataCollectionEnabled?: boolean;
-    // (undocumented)
     name?: string;
 }
 
-// @public (undocumented)
+// @internal (undocumented)
 export interface _FirebaseAppInternal extends FirebaseApp {
     // (undocumented)
     checkDestroyed(): void;
@@ -58,7 +56,7 @@ export interface _FirebaseAppInternal extends FirebaseApp {
     isDeleted: boolean;
 }
 
-// @public (undocumented)
+// @public
 export interface FirebaseOptions {
     // (undocumented)
     apiKey?: string;

packages-exp/app-compat/src/public-types.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2021 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages-exp/app-exp/src/public-types.ts

@@ -69,6 +69,8 @@ export interface FirebaseApp {
 
 /**
  * @public
+ *
+ * Firebase configuration object
  */
 export interface FirebaseOptions {
   apiKey?: string;
@@ -83,9 +85,18 @@ export interface FirebaseOptions {
 
 /**
  * @public
+ *
+ * Configuration options given to {@link (initializeApp:1) | initializeApp()}
  */
 export interface FirebaseAppConfig {
+  /**
+   * custom name for the Firebase App.
+   * The default value is `"[DEFAULT]"`.
+   */
   name?: string;
+  /**
+   * The settable config flag for GDPR opt-in/opt-out
+   */
   automaticDataCollectionEnabled?: boolean;
 }
 
@@ -102,6 +113,9 @@ export interface _FirebaseService {
   _delete(): Promise<void>;
 }
 
+/**
+ * @internal
+ */
 export interface _FirebaseAppInternal extends FirebaseApp {
   container: ComponentContainer;
   isDeleted: boolean;