Code review

samtstern · samtstern · commit 05e6e0aa4508 · 2020-09-25T10:53:46.000+01:00
diff --git a/packages-exp/functions-exp/src/service.ts b/packages-exp/functions-exp/src/service.ts
@@ -101,10 +101,10 @@ export class FunctionsService implements _FirebaseService {
     try {
       const url = new URL(regionOrCustomDomain);
       this.customDomain = url.origin;
-      this.region = 'us-central1';
+      this.region = DEFAULT_REGION;
     } catch (e) {
       this.customDomain = null;
-      this.region = DEFAULT_REGION;
+      this.region = regionOrCustomDomain;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -101,10 +101,10 @@ export class FunctionsService implements _FirebaseService {`
`101`	`101`	`try {`
`102`	`102`	`const url = new URL(regionOrCustomDomain);`
`103`	`103`	`this.customDomain = url.origin;`
`104`		`- this.region = 'us-central1';`
	`104`	`+ this.region = DEFAULT_REGION;`
`105`	`105`	`} catch (e) {`
`106`	`106`	`this.customDomain = null;`
`107`		`- this.region = DEFAULT_REGION;`
	`107`	`+ this.region = regionOrCustomDomain;`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`