Skip to content

Commit 027a783

Browse files
Actually fix resume token debugging in spec tests (#2877)
1 parent 5a63738 commit 027a783

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/firestore/test/unit/specs/spec_test_runner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1206,7 +1206,7 @@ abstract class TestRunner {
12061206
`ResumeToken does not match - expected:
12071207
${stringFromBase64String(
12081208
expectedTarget.resumeToken
1209-
)}, actual: ${stringFromBase64String(expectedTarget.resumeToken)}`
1209+
)}, actual: ${stringFromBase64String(actualTarget.resumeToken)}`
12101210
);
12111211
delete actualTargets[targetId];
12121212
});

packages/firestore/test/util/helpers.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,13 +524,12 @@ export function byteStringFromString(value: string): ByteString {
524524
*/
525525
export function stringFromBase64String(
526526
value?: string | Uint8Array
527-
): ByteString {
527+
): string {
528528
assert(
529529
value === undefined || typeof value === 'string',
530530
'Can only decode base64 encoded strings'
531531
);
532-
const base64 = PlatformSupport.getPlatform().btoa(value ?? '');
533-
return ByteString.fromBase64String(base64);
532+
return PlatformSupport.getPlatform().atob(value ?? '');
534533
}
535534

536535
/** Creates a resume token to match the given snapshot version. */

0 commit comments

Comments
 (0)