fix tests

Author: Feiyang1

packages/storage/compat/index.ts

@@ -50,8 +50,6 @@ function factory(
     .getProvider('storage-exp')
     .getImmediate({ identifier: url });
 
-  // TODO: get StorageService instance from component framework instead
-  // of creating a new one.
   const storageServiceCompat: StorageServiceCompat = new StorageServiceCompat(
     app,
     storageExp

packages/storage/package.json

@@ -30,6 +30,7 @@
     "test:browser:compat": "karma start --single-run --compat",
     "test:browser:exp": "karma start --single-run --exp",
     "test:browser": "karma start --single-run",
+    "test:debug": "karma start --browser=Chrome",
     "prettier": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
     "api-report": "api-extractor run --local --verbose && ts-node-script ../../repo-scripts/prune-dts/prune-dts.ts --input exp/dist/storage-public.d.ts --output exp/dist/storage-public.d.ts"
   },

packages/storage/test/integration/integration.compat.test.ts

@@ -23,7 +23,7 @@ import '@firebase/auth';
 import * as storage from '@firebase/storage-types';
 
 import { expect } from 'chai';
-import '../../compat/index';
+import '../../index';
 
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const PROJECT_CONFIG = require('../../../../config/project.json');

packages/storage/test/unit/index.compat.test.ts

@@ -15,10 +15,11 @@
  * limitations under the License.
  */
 import { expect } from 'chai';
-import '../../compat/index';
+import '../../index';
 import firebase from '@firebase/app';
 // eslint-disable-next-line import/no-extraneous-dependencies
 import { StorageServiceCompat } from '../../compat/service';
+import { StorageService } from '../../src/service';
 
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const PROJECT_CONFIG = require('../../../../config/project.json');
@@ -38,7 +39,8 @@ describe('Firebase Storage > API', () => {
     });
     const storage = firebase.storage!();
     expect(
-      (storage as StorageServiceCompat)._delegate._bucket?.bucket
+      ((storage as StorageServiceCompat)._delegate as StorageService)._bucket
+        ?.bucket
     ).to.equal(STORAGE_BUCKET);
     await app.delete();
   });
@@ -51,7 +53,8 @@ describe('Firebase Storage > API', () => {
     });
     const storage = firebase.storage!(app, 'gs://foo-bar.appspot.com');
     expect(
-      (storage as StorageServiceCompat)._delegate._bucket?.bucket
+      ((storage as StorageServiceCompat)._delegate as StorageService)._bucket
+        ?.bucket
     ).to.equal(STORAGE_BUCKET);
     await app.delete();
   });

packages/storage/test/unit/service.compat.test.ts

@@ -298,7 +298,7 @@ GOOG4-RSA-SHA256`
     });
     it('Running uploads fail when the service is deleted', () => {
       const ref = service.refFromURL('gs://mybucket/image.jpg');
-      const toReturn = new Promise((resolve, reject) => {
+      const toReturn = new Promise<void>((resolve, reject) => {
         ref.put(new Blob(['a'])).on(
           TaskEvent.STATE_CHANGED,
           null,

packages/storage/test/unit/service.exp.test.ts

@@ -298,7 +298,7 @@ GOOG4-RSA-SHA256`
     });
     it('Running uploads fail when the service is deleted', () => {
       const reference = ref(service, 'gs://mybucket/image.jpg');
-      const toReturn = new Promise((resolve, reject) => {
+      const toReturn = new Promise<void>((resolve, reject) => {
         uploadBytesResumable(reference, new Blob(['a'])).on(
           TaskEvent.STATE_CHANGED,
           undefined,

packages/storage/test/unit/task.test.ts

@@ -115,7 +115,7 @@ describe('Firebase Storage > Upload Task', () => {
     h1();
     h2();
 
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       task.on(
         TaskEvent.STATE_CHANGED,
         undefined,
@@ -136,7 +136,7 @@ describe('Firebase Storage > Upload Task', () => {
       new Reference(storageService, testLocation),
       smallBlob
     );
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       task.on(TaskEvent.STATE_CHANGED, {
         error: () => {
           assert.fail('Unexpected upload failure');