diff --git a/Example/Database/Tests/Unit/FPruneForestTest.m b/Example/Database/Tests/Unit/FPruneForestTest.m index 0694ba7d258..a75fba2aefd 100644 --- a/Example/Database/Tests/Unit/FPruneForestTest.m +++ b/Example/Database/Tests/Unit/FPruneForestTest.m @@ -57,7 +57,7 @@ - (void) testKeepUnderPruneWorks { FPruneForest *forest = [FPruneForest empty]; forest = [forest prunePath:[FPath pathWithString:@"foo/bar"]]; forest = [forest keepPath:[FPath pathWithString:@"foo/bar/baz"]]; - forest = [forest keepAll:[NSSet setWithArray:@[@"qux", @"quu"]] atPath:[FPath pathWithString:@"foo/bar"]]; + [forest keepAll:[NSSet setWithArray:@[@"qux", @"quu"]] atPath:[FPath pathWithString:@"foo/bar"]]; } - (void) testPruneUnderKeepThrows { diff --git a/Example/DynamicLinks/Tests/FIRDLScionLoggingTest.m b/Example/DynamicLinks/Tests/FIRDLScionLoggingTest.m index 532621174a6..47778c34708 100644 --- a/Example/DynamicLinks/Tests/FIRDLScionLoggingTest.m +++ b/Example/DynamicLinks/Tests/FIRDLScionLoggingTest.m @@ -60,7 +60,7 @@ - (void)clearConditionalUserProperty:(nonnull NSString *)userPropertyName - (nonnull NSArray *) conditionalUserProperties:(nonnull NSString *)origin propertyNamePrefix:(nonnull NSString *)propertyNamePrefix { - return nil; + return @[]; } - (NSInteger)maxUserProperties:(nonnull NSString *)origin { diff --git a/Example/Firebase.xcodeproj/xcshareddata/xcschemes/AllUnitTests_iOS.xcscheme b/Example/Firebase.xcodeproj/xcshareddata/xcschemes/AllUnitTests_iOS.xcscheme index 52626e65803..52d38c8a9b4 100644 --- a/Example/Firebase.xcodeproj/xcshareddata/xcschemes/AllUnitTests_iOS.xcscheme +++ b/Example/Firebase.xcodeproj/xcshareddata/xcschemes/AllUnitTests_iOS.xcscheme @@ -11,7 +11,7 @@ buildForRunning = "YES" buildForProfiling = "NO" buildForArchiving = "NO" - buildForAnalyzing = "NO"> + buildForAnalyzing = "YES"> + buildForAnalyzing = "YES"> + buildForAnalyzing = "YES"> + buildForAnalyzing = "YES"> + buildForAnalyzing = "YES"> + buildForAnalyzing = "YES"> + buildForAnalyzing = "YES"> + + + + *) conditionalUserProperties:(nonnull NSString *)origin propertyNamePrefix:(nonnull NSString *)propertyNamePrefix { - return nil; + return @[]; } - (NSInteger)maxUserProperties:(nonnull NSString *)origin { diff --git a/Firebase/DynamicLinks/FDLURLComponents/FDLURLComponents.m b/Firebase/DynamicLinks/FDLURLComponents/FDLURLComponents.m index 05c708bf4ff..9c6a0062ae0 100644 --- a/Firebase/DynamicLinks/FDLURLComponents/FDLURLComponents.m +++ b/Firebase/DynamicLinks/FDLURLComponents/FDLURLComponents.m @@ -25,7 +25,7 @@ /// The exact behavior of dict[key] = value is unclear when value is nil. This function safely adds /// the key-value pair to the dictionary, even when value is nil. /// This function will treat empty string in the same way as nil. -NS_INLINE void FDLSafelyAddKeyValuePairToDictionary(id key, +NS_INLINE void FDLSafelyAddKeyValuePairToDictionary(NSString *key, NSString *stringValue, NSMutableDictionary *dictionary) { if (stringValue != nil && stringValue.length > 0) { diff --git a/Firebase/DynamicLinks/FIRDLDefaultRetrievalProcessV2.m b/Firebase/DynamicLinks/FIRDLDefaultRetrievalProcessV2.m index 39a48ed7e04..efdd51fcc8a 100644 --- a/Firebase/DynamicLinks/FIRDLDefaultRetrievalProcessV2.m +++ b/Firebase/DynamicLinks/FIRDLDefaultRetrievalProcessV2.m @@ -213,7 +213,7 @@ - (void)retrievePendingDynamicLinkInternal { return [self.requestResults filteredArrayUsingPredicate:predicate]; } -- (FIRDLRetrievalProcessResult *)resultWithUniqueMatchedDynamicLink { +- (nullable FIRDLRetrievalProcessResult *)resultWithUniqueMatchedDynamicLink { // return result with unique-matched dynamic link if found NSArray *foundResultsWithDynamicLinks = [self foundResultsWithDynamicLinks]; diff --git a/Firebase/DynamicLinks/FIRDynamicLinks.m b/Firebase/DynamicLinks/FIRDynamicLinks.m index cf02f35c4f8..f12c0ed84c0 100644 --- a/Firebase/DynamicLinks/FIRDynamicLinks.m +++ b/Firebase/DynamicLinks/FIRDynamicLinks.m @@ -188,8 +188,8 @@ - (void)configureDynamicLinks:(FIRApp *)app { service:kFIRServiceDynamicLinks reason:errorDescription]; } - [app sendLogsWithServiceName:kFIRServiceDynamicLinks version:kFIRDLVersion error:error]; if (error) { + [app sendLogsWithServiceName:kFIRServiceDynamicLinks version:kFIRDLVersion error:error]; NSString *message = nil; if (options.usingOptionsFromDefaultPlist) { // Configured using plist file